Page MenuHomeFreeBSD

Add missing no-ctfconvert to C generation rules
ClosedPublic

Authored by andrew on Jan 14 2021, 3:42 PM.

Details

Summary

Stop running ctfconvert over generated C files in the kernel by marking
them with no-ctfconvert.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Looks fine to me. Is there anything specific that made you notice this?

This revision is now accepted and ready to land.Jan 15 2021, 3:27 AM
mmel added a subscriber: mmel.

LGTM. thanks.
It is a bit questionable whether ctfconvert should generate an error in this case (I don't think so), but calling it is clearly unnecessary in this case.

It fixes warning similar to the following. This is because it's running ctfconvert on the .c file rather than a .o file.

ctfconvert: rtwn-rtl8821aufw.c: Couldn't read ehdr: Invalid argument