Page MenuHomeFreeBSD

Add missing no-ctfconvert to C generation rules
ClosedPublic

Authored by andrew on Jan 14 2021, 3:42 PM.
Tags
None
Referenced Files
F80201692: D28156.id.diff
Fri, Mar 29, 5:30 AM
Unknown Object (File)
Thu, Mar 7, 4:07 PM
Unknown Object (File)
Sat, Mar 2, 2:14 AM
Unknown Object (File)
Jan 11 2024, 12:15 AM
Unknown Object (File)
Dec 20 2023, 6:10 PM
Unknown Object (File)
Dec 20 2023, 8:29 AM
Unknown Object (File)
Nov 28 2023, 8:58 PM
Unknown Object (File)
Nov 22 2023, 5:44 PM
Subscribers

Details

Summary

Stop running ctfconvert over generated C files in the kernel by marking
them with no-ctfconvert.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks fine to me. Is there anything specific that made you notice this?

This revision is now accepted and ready to land.Jan 15 2021, 3:27 AM
mmel added a subscriber: mmel.

LGTM. thanks.
It is a bit questionable whether ctfconvert should generate an error in this case (I don't think so), but calling it is clearly unnecessary in this case.

It fixes warning similar to the following. This is because it's running ctfconvert on the .c file rather than a .o file.

ctfconvert: rtwn-rtl8821aufw.c: Couldn't read ehdr: Invalid argument