hid: Fix LINT build
ClosedPublic
Actions

Authored by wulf on Jan 9 2021, 11:08 AM.

Details

Reviewers

Commits

rG0f0379fa5581: hid: Add recently imported drivers to NOTES

Summary

Add NOTES entries and fix extraneous SYSCTL_ADD_INT() options revealed by LINT build

Test Plan

build LINT kernel

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

wulf requested review of this revision.Jan 9 2021, 11:08 AM

sys/conf/NOTES
2856	I already added "device hid" in NOTES, so please rebase your patch!

sys/amd64/conf/NOTES
610–616	Please remove this \r character while at it :-)
sys/i386/conf/NOTES
863–869	Ditto.

Rebased on top of main

wulf marked 2 inline comments as done.Jan 9 2021, 12:13 PM

wulf added inline comments.

Looks good. Just make sure LINT builds.

sys/conf/NOTES
2415–2416	# Generic HID support -> # HID support

This revision is now accepted and ready to land.Jan 9 2021, 5:04 PM

imp added inline comments.

sys/amd64/conf/NOTES
613	I'd prefer we put this in sys/conf/NOTES as well. And for mips/powerpc remove it in those notes files with nodevice if needed. It's supported on all the 'mainstream' ports and there's nothing specific to the architecture in these files that I've noticed. I think the duplication of the other options is worse than just having a nodevice or two if it turns out not to build there.
sys/conf/NOTES
2598	Is there some reason this is commented out? If it's not normally on in GENERIC, it should be here, if it is normally on and we want to support things with it off, it shouldn't be here, though it's a mixed bag if that's commented out with a comment about why or it simply not here. I prefer the former. But commented out w/o a reason will invite others to remove either the '#' or the whole thing when 'cleaning up' this.
sys/dev/hid/hidmap.c
755 ↗	(On Diff #81947)	This is unrelated and should be committed separately, here and elsewhere in this review (iichid.c)

wulf marked 3 inline comments as done.Jan 9 2021, 8:50 PM

wulf added inline comments.

sys/amd64/conf/NOTES
613	HID-over-I2C depends on ACPI as it read configuration through _DSM method call (Microsoft specs requires that). That means it is architecture dependent at least for now. If someone knows how to attach such a devices with FDT, it is easy to fix as all ACPI parts are isolated in probe() method.
sys/conf/NOTES
2598	This option only changes usbhid probe priority and adds/removes PnP IDs to different drivers. I will add comment about that. IMO there is no difference if it is enabled or is disabled in LINT.
sys/dev/hid/hidmap.c
755 ↗	(On Diff #81947)	sysctl changes stays in separate commit in my repo.