Differential D19830

Create sys/reg.h for the common code previously in machine/reg.h
ClosedPublic
Actions

Authored by andrew on Apr 5 2019, 12:35 PM.

Tags

None

Referenced Files

	F148659449: D19830.diff
	Thu, Mar 19, 10:49 AM

	F148617453: D19830.diff
	Thu, Mar 19, 4:20 AM

	Unknown Object (File)
	Fri, Feb 20, 3:07 PM

	Unknown Object (File)
	Feb 16 2026, 7:06 PM

	Unknown Object (File)
	Jan 31 2026, 9:23 AM

	Unknown Object (File)
	Jan 29 2026, 9:22 PM

	Unknown Object (File)
	Jan 29 2026, 9:22 PM

	Unknown Object (File)
	Jan 28 2026, 7:14 AM

Subscribers

Details

Reviewers

jhb
manu
markj
imp
gnn

Group Reviewers

Commits

rGe5e2c7ffa0f7: Create sys/reg.h for the common code previously in machine/reg.h
rGb792434150d6: Create sys/reg.h for the common code previously in machine/reg.h

Summary

This is in preperation for adding PT_GETREGSET

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Apr 5 2019, 12:35 PM

Herald added a reviewer: manu. · View Herald TranscriptApr 5 2019, 12:35 PM

Herald added subscribers: bdragon, jhibbits. · View Herald Transcript

Harbormaster completed remote builds in B23534: Diff 55837.Apr 5 2019, 12:35 PM

andrew added a child revision: D19831: Add PT_GETREGSET.Apr 5 2019, 12:37 PM

Rebase

Herald added a reviewer: bhyve. · View Herald TranscriptAug 27 2021, 11:15 AM

Herald added subscribers: bcran, rgrimes, rpokala, imp. · View Herald Transcript

Harbormaster completed remote builds in B41237: Diff 94268.Aug 27 2021, 11:15 AM

markj added a subscriber: markj.Aug 27 2021, 3:21 PM

markj added inline comments.

sys/mips/include/reg.h
98	Is this forward declaration needed?
sys/x86/include/reg.h
246–247	I think this declaration isn't needed anymore.

Remove unneeded forward declarations

Harbormaster completed remote builds in B41239: Diff 94287.Aug 27 2021, 4:04 PM

markj accepted this revision as: markj.Aug 28 2021, 12:12 AM

This revision is now accepted and ready to land.Aug 28 2021, 12:12 AM

imp accepted this revision.Aug 28 2021, 12:25 AM

jhb accepted this revision.Aug 30 2021, 5:59 PM

jhb added inline comments.

sys/x86/include/reg.h
246–247	The comment isn't needed, but the function still exists. It is shared between DTrace and fill_regs().

Closed by commit rGb792434150d6: Create sys/reg.h for the common code previously in machine/reg.h (authored by andrew). · Explain WhyOct 26 2021, 6:24 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGb792434150d6: Create sys/reg.h for the common code previously in machine/reg.h.

Herald added a reviewer: gnn. · View Herald TranscriptOct 26 2021, 6:24 PM

jhb added a commit: rGe5e2c7ffa0f7: Create sys/reg.h for the common code previously in machine/reg.h.May 22 2022, 1:01 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

2 lines

2 lines

2 lines

ia32/

1 line

include/

1 line

linux/

1 line

linux32/

linux32_machdep.c

2 lines

vmm/

amd/

2 lines

intel/

2 lines

arm/

arm/

debug_monitor.c

2 lines

2 lines

include/

9 lines

arm64/

arm64/

2 lines

include/

20 lines

linux/

linux_machdep.c

3 lines

cddl/

contrib/

opensolaris/

uts/

intel/

dtrace/

2 lines

dev/

dtrace/

aarch64/

1 line

amd64/

1 line

arm/

1 line

mips/

1 line

powerpc/

1 line

riscv/

1 line

compat/

linux/

1 line

ddb/

1 line

fs/

procfs/

procfs_dbregs.c

2 lines

procfs_fpregs.c

2 lines

2 lines

i386/

i386/

2 lines

2 lines

2 lines

include/

1 line

linux/

1 line

kern/

1 line

3 lines

3 lines

mips/

include/

2 lines

16 lines

mips/

freebsd32_machdep.c

2 lines

1 line

1 line

2 lines

nlm/

1 line

dev/

net/

1 line

powerpc/

aim/

1 line

booke/

booke_machdep.c

1 line

fpu/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

powerpc/

elf32_machdep.c

2 lines

2 lines

1 line

2 lines

riscv/

include/

12 lines

riscv/

2 lines

	sys/
	arm64/	include/

76 lines

x86/

include/

16 lines

x86/

1 line

Diff 97498

sys/amd64/amd64/db_trace.c

Loading...

sys/amd64/amd64/gdb_machdep.c

Loading...

sys/amd64/amd64/machdep.c

Loading...

sys/amd64/ia32/ia32_reg.c

Loading...

sys/amd64/include/db_machdep.h

Loading...

sys/amd64/linux/linux_ptrace.c

Loading...

sys/amd64/linux32/linux32_machdep.c

Loading...

sys/amd64/vmm/amd/svm.c

Loading...

sys/amd64/vmm/intel/vmx.c

Loading...

sys/arm/arm/debug_monitor.c

Loading...

sys/arm/arm/machdep_kdb.c

Loading...

sys/arm/include/reg.h

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/arm64/include/reg.h

Loading...

sys/arm64/linux/linux_machdep.c

Loading...

sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c

Loading...

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c

Loading...

sys/cddl/dev/dtrace/amd64/dtrace_isa.c

Loading...

sys/cddl/dev/dtrace/arm/dtrace_isa.c

Loading...

sys/cddl/dev/dtrace/mips/dtrace_isa.c

Loading...

sys/cddl/dev/dtrace/powerpc/dtrace_isa.c

Loading...

sys/cddl/dev/dtrace/riscv/dtrace_isa.c

Loading...

sys/compat/linux/linux_elf.c

Loading...

sys/ddb/db_run.c

Loading...

sys/fs/procfs/procfs_dbregs.c

Loading...

sys/fs/procfs/procfs_fpregs.c

Loading...

sys/fs/procfs/procfs_regs.c

Loading...

sys/i386/i386/db_trace.c

Loading...

sys/i386/i386/gdb_machdep.c

Loading...

sys/i386/i386/machdep.c

Loading...

sys/i386/include/db_machdep.h

Loading...

sys/i386/linux/linux_ptrace.c

Loading...

sys/kern/imgact_elf.c

Loading...

sys/kern/kern_exec.c

Loading...

sys/kern/sys_process.c

Loading...

sys/mips/include/md_var.h

Loading...

sys/mips/include/reg.h

Loading...

sys/mips/mips/freebsd32_machdep.c

Loading...

sys/mips/mips/gdb_machdep.c

Loading...

sys/mips/mips/machdep.c

Loading...

sys/mips/mips/pm_machdep.c

Loading...

sys/mips/nlm/cms.c

Loading...

sys/mips/nlm/dev/net/xlpge.c

Loading...

sys/powerpc/aim/aim_machdep.c

Loading...

sys/powerpc/booke/booke_machdep.c

Loading...

sys/powerpc/fpu/fpu_add.c

Loading...

sys/powerpc/fpu/fpu_compare.c

Loading...

sys/powerpc/fpu/fpu_div.c

Loading...

sys/powerpc/fpu/fpu_emu.c

Loading...

sys/powerpc/fpu/fpu_implode.c

Loading...

sys/powerpc/fpu/fpu_mul.c

Loading...

sys/powerpc/fpu/fpu_sqrt.c

Loading...

sys/powerpc/fpu/fpu_subr.c

Loading...

sys/powerpc/powerpc/elf32_machdep.c

Loading...

sys/powerpc/powerpc/exec_machdep.c

Loading...

sys/powerpc/powerpc/gdb_machdep.c

Loading...

sys/powerpc/powerpc/machdep.c

Loading...

sys/riscv/include/reg.h

Loading...

sys/riscv/riscv/machdep.c

Loading...

sys/sys/reg.h

Loading...

sys/x86/include/reg.h

Loading...

sys/x86/x86/dbreg.c

Loading...