Rebase to main. follow parent commit update and resolve conflict with a2eb0894b79b.

Update by rebase to main. follow update by parent revision.

Update by rebase to main. resolve conflict with 9df6a7f9a60b in ip6_var.h.

kind ping: @ae @melifaro

Do you have time to review this change?
@ae @zlei

friendly reminder on our conversation about privacy concerns over IPv6 flow_id.
@rscheff

kind ping @tuexen @rscheff

kind ping @bz

add nl_parsed_gre to test file.

Make nl_parsed_gre private.
@zlei done.
After doing my research, If find out you were right.
Dictating netlink data structure to userland defeats
the purpose of using netlink in first place.

Rebase geneve to main and limit this revision kernel only.
ifconfig netlink helper: D55174
ifconfig geneve implementation (netlink): D55184
ifconfig geneve implementation (without netlink): D55185
ifconfig(8) manual for geneve: D55181
geneve(4) manual: D55182
geneve tests: D55183
update geneve to follow RFC 6040: D55186

I'm going to breakdown this revision to be easier to review.
So, sorry for noise in advance.

@zlei
Did my answer resolve you comments?
Do you have any other input?

LGTM

Move netlink related functions to the end of file.
@zlei done.

@zlei
Can I have your opinion on this review, too?
I'm ready to commit it, but I'd prefer to wait for your feedback as well.

In D54443#1259973, @ae wrote:

Can you take a look at this patch? Maybe you can reuse some pieces, it should fix 275474 and also make access to softc in a safer way.

rename nd6_queue to nd_queue to match the style of in6_ifextra
rebase from main to update parent commit

Rollback. wrong revision. sorry for noise!

Replace callout_init_mtx with callout_init_rw. (Oops!)
Interesting enough, I tested every part my code. everything works.
nobody complains that I used callout_init_rw and passed a mutex!

Move nd6_queue tailq to in6_ifextra.
initialize nd6_queue at nd6_ifattach.
Reuse IF_ADDR_WLOCK as wlock of tailq.
Use epoch(9) as rlock.

LGTM

In D54443#1259973, @ae wrote:

Can you take a look at this patch? Maybe you can reuse some pieces, it should fix 275474 and also make access to softc in a safer way.

Add break to MOD_LOAD to address @glebius comment.

In D55015#1259505, @glebius wrote:

I didn't ask to de-virtualize the queue, only the lock.

I'm confused now, how can I initialize a single lock for each per-vnet queue?
If I use an static initializer I need to tell/assign which per-vnet queue:

VNET_DEFINE_STATIC(TAILQ_HEAD(, nd6_queue), nd6_queue);
#define V_nd6_queue             VNET(nd6_queue)

In D55015#1259505, @glebius wrote:

Sorry, I didn't ask to de-virtualize the queue, only the lock.

I misunderstood you message. I'll fix it right away!

rename nd6 queue flags from GRAND to QUEUE to reuse nd6_queue in future.

So, seems like 14.4-BETA1 checkout happens at February 6.
@glebius I need approval for MFC within 1 day.

Don't virtualize nd6_queue.
@glebius Done.

In D55099#1259415, @zlei wrote:

Looks good to me.

In D55099#1259353, @pouria wrote:

@glebius can I MFC this into stable/15 within 3 days?

Do you actually want to MFC to stable/14 to catch up with 14.4-BETA1 ? I see no problems.

• Add types in if_gre.h to fix world build
• Add copyright to test_rtnl_gre.c
• Rebase to main and fix cleanup in test_rtnl_gre.

@glebius done.

@glebius can I MFC this into stable/15 within 3 days?

In D54443#1257878, @zlei wrote:

There're three tasks in this change,

1. Migrate to new if_clone KPI
2. Refactor some ioctls, say GRESKEY
3. Add netlink support

The first two are simple and easy to review, I expect them can be landed quickly. I'd support you to split the change.

kind reminder
@glebius

kind reminder.
@tuexen @rscheff

@bz I've fixed the c&p error to address your comments. Could you please take another look?

Rename struct and function. no functional change.

Please fixs those on CURRENT. For this MFC, LGTM.

Fix manual style/warning nits

Fix some style(9) nits.

LGTM

@glebius Can I commit it with a 1-week MFC?

@bz Done. sorry, I missed that comment.

In D54636#1254216, @bz wrote:

There's still some c&p error in the man page.

Could you please specify which part of the man page you think contains c&p errors, so I can work on it?

@bz done.

@bz I've made some changes to address your comments. Could you please take another look?

Add a temporary comment to land this patch

Avoid returning badkey error for EDDSA.

@ziaee
Thank you for reviewing the 53786 . I wanted to politely ping you on this revision, when you have a chance.

@glebius can I commit this revision?

LGTM
I also tested interface creation and destruction to advertise/withdraw its routes with bird3 (ospf) and openbgpd8.

LGTM.
I also tested with the CSUM_IP patch applied to if_epair.c:447 and saw good results.