Page MenuHomeFreeBSD
Differential D55410

tcp: improve validation of received TCP over UDP packets
ClosedPublic
Actions

Authored by tuexen on Fri, Feb 20, 8:46 PM.

Details

Reviewers
rrs
glebius
timo.voelker_fh-muenster.de
pouria
Group Reviewers
transport
Commits
rGe1886559ea47: tcp: improve validation of received TCP over UDP packets

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Fri, Feb 20, 8:46 PM
Herald added a reviewer: transport. · View Herald TranscriptFri, Feb 20, 8:46 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Fri, Feb 20, 8:46 PM
pouria accepted this revision as: pouria.Fri, Feb 20, 9:02 PM
pouria added a subscriber: pouria.

LGTM

sys/netinet/tcp_subr.c
623

__predict_false?

glebius added a comment.Fri, Feb 20, 9:05 PM

I'd suggest to change to title to explictily say "TCP over UDP", cause "TCP/UDP" can be misinterpreted to a change to TCP and a similar change to UDP.

glebius accepted this revision.Fri, Feb 20, 9:06 PM
tuexen retitled this revision from tcp: improve validation of received TCP/UDP packets to tcp: improve validation of received TCP over UDP packets.Fri, Feb 20, 9:12 PM
tuexen accepted this revision as: transport.Fri, Feb 20, 9:17 PM
This revision is now accepted and ready to land.Fri, Feb 20, 9:17 PM
Closed by commit rGe1886559ea47: tcp: improve validation of received TCP over UDP packets (authored by tuexen). · Explain WhyFri, Feb 20, 9:24 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGe1886559ea47: tcp: improve validation of received TCP over UDP packets.
tuexen marked an inline comment as done.Fri, Feb 20, 9:30 PM
tuexen added inline comments.
sys/netinet/tcp_subr.c
623

Will put that in a cleanup I will make.

Revision Contents
Changeset List

PathSize
sys/
netinet/
22 lines

Diff 172350

View Options

sys/netinet/tcp_subr.c

Loading...