Page MenuHomeFreeBSD
Differential D55410

tcp: improve validation of received TCP over UDP packets
ClosedPublic
Actions

Authored by tuexen on Feb 20 2026, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 19, 6:41 AM
Unknown Object (File)
Tue, Mar 17, 8:15 AM
Unknown Object (File)
Sat, Mar 14, 12:46 PM
Unknown Object (File)
Wed, Mar 11, 10:23 AM
Unknown Object (File)
Mon, Mar 9, 2:42 PM
Unknown Object (File)
Sun, Mar 8, 10:34 PM
Unknown Object (File)
Mon, Mar 2, 12:05 PM
Unknown Object (File)
Mon, Mar 2, 10:26 AM
View All 13 Files
Subscribers
bms
gnn
imp
melifaro
pouria
rgrimes

Details

Reviewers
rrs
glebius
timo.voelker_fh-muenster.de
pouria
Group Reviewers
transport
Commits
rGe1886559ea47: tcp: improve validation of received TCP over UDP packets

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Feb 20 2026, 8:46 PM
Herald added a reviewer: transport. · View Herald TranscriptFeb 20 2026, 8:46 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Feb 20 2026, 8:46 PM
pouria accepted this revision as: pouria.Feb 20 2026, 9:02 PM
pouria added a subscriber: pouria.

LGTM

sys/netinet/tcp_subr.c
623

__predict_false?

glebius added a comment.Feb 20 2026, 9:05 PM

I'd suggest to change to title to explictily say "TCP over UDP", cause "TCP/UDP" can be misinterpreted to a change to TCP and a similar change to UDP.

glebius accepted this revision.Feb 20 2026, 9:06 PM
tuexen retitled this revision from tcp: improve validation of received TCP/UDP packets to tcp: improve validation of received TCP over UDP packets.Feb 20 2026, 9:12 PM
tuexen accepted this revision as: transport.Feb 20 2026, 9:17 PM
This revision is now accepted and ready to land.Feb 20 2026, 9:17 PM
Closed by commit rGe1886559ea47: tcp: improve validation of received TCP over UDP packets (authored by tuexen). · Explain WhyFeb 20 2026, 9:24 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGe1886559ea47: tcp: improve validation of received TCP over UDP packets.
tuexen marked an inline comment as done.Feb 20 2026, 9:30 PM
tuexen added inline comments.
sys/netinet/tcp_subr.c
623

Will put that in a cleanup I will make.

bms added a subscriber: bms.Feb 21 2026, 12:23 PM
timo.voelker_fh-muenster.de added a comment.Feb 22 2026, 10:53 AM

I agree on @pouria's comment.

A __predict_false makes sense in the IPv6 case as well.

bms added subscribers: rgrimes, gnn.Feb 22 2026, 12:51 PM
In D55410#1267939, @timo.voelker_fh-muenster.de wrote:

I agree on @pouria's comment.

A __predict_false makes sense in the IPv6 case as well.

Had to do the same for SBR-ILNP for IPv6 vs ILNPv6 flows, in ip6_forward(), when deciding whether or not to call ilnp6_forward(), which currently exists only in the sup3r s3krt bms dSBR-ILNP branch. @rgrimes will probably not have to deal with this as it wasn't really a issue for hosts.

Currently busy spinning up on SRv6. The code archeaology of FreeBSD vs source routing is a story for another time. I see @gnn knows where some of the bodies are buried there.

tuexen marked an inline comment as done.Feb 22 2026, 1:14 PM
In D55410#1267939, @timo.voelker_fh-muenster.de wrote:

I agree on @pouria's comment.

A __predict_false makes sense in the IPv6 case as well.

Done in D55415.

Revision Contents
Changeset List

PathSize
sys/
netinet/
22 lines

Diff 172350

View Options

sys/netinet/tcp_subr.c

Loading...