Page MenuHomeFreeBSD
Differential D55613

rtnetlink: call rt_get_rnd when required in getroute
AbandonedPublic
Actions

Authored by pouria on Mar 2 2026, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 4:04 PM
Unknown Object (File)
Wed, Apr 22, 7:43 PM
Unknown Object (File)
Sat, Apr 18, 10:55 AM
Unknown Object (File)
Fri, Apr 17, 9:24 AM
Unknown Object (File)
Sat, Apr 11, 7:31 PM
Unknown Object (File)
Tue, Apr 7, 2:52 PM
Unknown Object (File)
Mar 26 2026, 12:06 AM
Unknown Object (File)
Mar 23 2026, 2:02 AM
View All 24 Files
Subscribers
imp

Details

Reviewers
melifaro
glebius
zlei
Group Reviewers
network
Summary

the rib_lookup_prefix_plen() will fill the rnd data structure
in handle_rtm_getroute.
Therefore, only call rt_get_rnd() when it's necessary.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71131
Build 68014: arc lint + arc unit

Event Timeline

pouria created this revision.Mar 2 2026, 3:00 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 2 2026, 3:00 PM
pouria requested review of this revision.Mar 2 2026, 3:00 PM
Harbormaster completed remote builds in B71131: Diff 173007.Mar 2 2026, 3:00 PM
glebius requested changes to this revision.Mar 2 2026, 4:43 PM

This can't be correct cause now rt_get_rnd() may receive a NULL argument and inside it definitely dereferences it.

This revision now requires changes to proceed.Mar 2 2026, 4:43 PM
pouria abandoned this revision.Mar 2 2026, 4:45 PM

Yes, I made a stupid mistake. Thank you!

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
6 lines

Diff 173007

View Options

sys/netlink/route/rt.c

Loading...