Paths

Table of Contentst

ipfw: Add ICMPv6 type(s) to ipfw syntax summary usage
Needs RevisionPublic
Actions

Authored by jlduran on Mar 1 2025, 4:57 PM.

Tags

None

Referenced Files

	F149177556: D49194.id.diff
	Sun, Mar 22, 7:12 PM

	Unknown Object (File)
	Sun, Mar 22, 8:12 AM

	Unknown Object (File)
	Thu, Mar 19, 4:51 AM

	Unknown Object (File)
	Sun, Mar 15, 11:43 PM

	Unknown Object (File)
	Thu, Mar 12, 8:57 PM

	Unknown Object (File)
	Wed, Mar 11, 9:42 AM

	Unknown Object (File)
	Jan 26 2026, 6:51 PM

	Unknown Object (File)
	Jan 26 2026, 1:01 PM

Subscribers

Details

Reviewers

emaste
pouria

Group Reviewers

network

Summary

Account for the IPv6 ICMP types in the usage. While here account for
both singular and plural forms as well.

PR: 284865

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62712
Build 59596: arc lint + arc unit

Event Timeline

jlduran created this revision.Mar 1 2025, 4:57 PM

Herald added subscribers: donner, imp. · View Herald TranscriptMar 1 2025, 4:57 PM

jlduran requested review of this revision.Mar 1 2025, 4:57 PM

Harbormaster completed remote builds in B62712: Diff 151718.Mar 1 2025, 4:57 PM

Adding both singular and plural form is good to me.
But adding another icmp6types is redundant.

sbin/ipfw/main.c
74	there is one `icmp6types` right here.

This revision now requires changes to proceed.Wed, Feb 25, 1:42 PM

pouria retitled this revision from ipfw: Add IPv6 ICMP type(s) to ipfw: Add ICMPv6 type(s) to ipfw syntax summary usage.Wed, Feb 25, 1:45 PM

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

main.c

4 lines

Diff 151718

View Options

ipfw: Add ICMPv6 type(s) to ipfw syntax summary usageNeeds RevisionPublicActions