Paths

Table of Contentst

ipfw: Add ICMPv6 type(s) to ipfw syntax summary usage
Needs ReviewPublic
Actions

Authored by jlduran on Mar 1 2025, 4:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 14, 1:13 AM

	Unknown Object (File)
	Tue, May 12, 12:42 AM

	Unknown Object (File)
	Sat, May 9, 12:51 PM

	Unknown Object (File)
	Tue, Apr 28, 4:20 PM

	Unknown Object (File)
	Tue, Apr 28, 4:15 PM

	Unknown Object (File)
	Thu, Apr 23, 12:12 PM

	Unknown Object (File)
	Thu, Apr 23, 9:11 AM

	Unknown Object (File)
	Mar 22 2026, 7:12 PM

Subscribers

Details

Reviewers

emaste
pouria

Group Reviewers

network

Summary

Account for the IPv6 ICMP types in the usage. While here account for
both singular and plural forms as well.

PR: 284865

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73178
Build 70061: arc lint + arc unit

Event Timeline

jlduran created this revision.Mar 1 2025, 4:57 PM

Herald added subscribers: donner, imp. · View Herald TranscriptMar 1 2025, 4:57 PM

jlduran requested review of this revision.Mar 1 2025, 4:57 PM

Harbormaster completed remote builds in B62712: Diff 151718.Mar 1 2025, 4:57 PM

Adding both singular and plural form is good to me.
But adding another icmp6types is redundant.

sbin/ipfw/main.c
74	there is one `icmp6types` right here.

This revision now requires changes to proceed.Feb 25 2026, 1:42 PM

pouria retitled this revision from ipfw: Add IPv6 ICMP type(s) to ipfw: Add ICMPv6 type(s) to ipfw syntax summary usage.Feb 25 2026, 1:45 PM

Address sugesstions:

Update the commit title
Remove duplicate icmp6types entry

Harbormaster completed remote builds in B73178: Diff 177992.Mon, May 18, 2:21 AM

jlduran marked an inline comment as done.Mon, May 18, 2:22 AM

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

main.c

6 lines

Diff 177992

View Options

ipfw: Add ICMPv6 type(s) to ipfw syntax summary usageNeeds ReviewPublicActions