Paths

Table of Contentst

ipfw: Add ICMPv6 type(s) to ipfw syntax summary usage
Needs ReviewPublic
Actions

Authored by jlduran on Mar 1 2025, 4:57 PM.

Tags

None

Referenced Files

	F158963273: D49194.id177992.diff
	Mon, Jun 8, 8:29 AM

	F158962848: D49194.id177992.diff
	Mon, Jun 8, 8:21 AM

	Unknown Object (File)
	Sun, Jun 7, 12:15 AM

	Unknown Object (File)
	Sun, Jun 7, 12:12 AM

	Unknown Object (File)
	Sat, Jun 6, 6:45 AM

	Unknown Object (File)
	Sat, Jun 6, 6:39 AM

	Unknown Object (File)
	Thu, Jun 4, 3:19 AM

	Unknown Object (File)
	Tue, Jun 2, 8:08 AM

Subscribers

Details

Reviewers

emaste
pouria

Group Reviewers

network

Summary

Account for the IPv6 ICMP types in the usage. While here account for
both singular and plural forms as well.

PR: 284865

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73178
Build 70061: arc lint + arc unit

Event Timeline

jlduran created this revision.Mar 1 2025, 4:57 PM

Herald added subscribers: donner, imp. · View Herald TranscriptMar 1 2025, 4:57 PM

jlduran requested review of this revision.Mar 1 2025, 4:57 PM

Harbormaster completed remote builds in B62712: Diff 151718.Mar 1 2025, 4:57 PM

Adding both singular and plural form is good to me.
But adding another icmp6types is redundant.

sbin/ipfw/main.c
74	there is one `icmp6types` right here.

This revision now requires changes to proceed.Feb 25 2026, 1:42 PM

pouria retitled this revision from ipfw: Add IPv6 ICMP type(s) to ipfw: Add ICMPv6 type(s) to ipfw syntax summary usage.Feb 25 2026, 1:45 PM

Address sugesstions:

Update the commit title
Remove duplicate icmp6types entry

Harbormaster completed remote builds in B73178: Diff 177992.Mon, May 18, 2:21 AM

jlduran marked an inline comment as done.Mon, May 18, 2:22 AM

pouria accepted this revision as: pouria.Mon, May 18, 5:19 PM

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

main.c

6 lines

Diff 177992

View Options

ipfw: Add ICMPv6 type(s) to ipfw syntax summary usageNeeds ReviewPublicActions