route: Fix -expire argument when using netlink
ClosedPublic
Actions

Authored by pouria on Sun, Feb 22, 6:45 PM.

Tags

None

Referenced Files

	F146631818: D55444.id.diff
	Wed, Mar 4, 6:45 AM

	Unknown Object (File)
	Tue, Mar 3, 5:01 AM

	Unknown Object (File)
	Tue, Mar 3, 1:28 AM

	Unknown Object (File)
	Mon, Mar 2, 2:10 AM

	Unknown Object (File)
	Sun, Mar 1, 3:31 AM

	Unknown Object (File)
	Fri, Feb 27, 5:01 PM

	Unknown Object (File)
	Wed, Feb 25, 6:42 AM

	Unknown Object (File)
	Wed, Feb 25, 6:41 AM

View All 11 Files

Subscribers

imp

zarychtam_plan-b.pwste.edu.pl

Details

Reviewers

glebius
melifaro
zlei
markj

Group Reviewers

network

Commits

rG8230cf1aa18d: route(8): Fix -expire argument when using netlink

Summary

Depends on D55442 for adding new route with -expire
argument.
Also fixes nexthop expire value on route get using netlink.

Test Plan

To test:

route -n6 add -host 3fff::1 -gateway ::1 -expire +10
route -n6 get 3fff::1

Also, checkout test plan in D55440.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Sun, Feb 22, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Feb 22, 6:45 PM

pouria requested review of this revision.Sun, Feb 22, 6:45 PM

Harbormaster completed remote builds in B70884: Diff 172458.Sun, Feb 22, 6:45 PM

glebius accepted this revision as: glebius.Thu, Feb 26, 3:19 AM

This revision is now accepted and ready to land.Thu, Feb 26, 3:19 AM

Closed by commit rG8230cf1aa18d: route(8): Fix -expire argument when using netlink (authored by pouria). · Explain WhyThu, Feb 26, 12:36 PM

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rG8230cf1aa18d: route(8): Fix -expire argument when using netlink.

I have been testing this patch on a couple of computers for over a week now, and everything seems to work fine (at least I see no regression).

Revision Contents
Changeset List

Path

Size

sbin/

route/

route_netlink.c

10 lines

Diff 172763

View Options

sbin/route/route_netlink.c

route: Fix -expire argument when using netlinkClosedPublicActions