Propose to use active voice in a sentence. The rest looks good.

Not much to do for manpage syntax here, so approved.

Address comments:

• turn $vars into ${var}
• quote them and the $()

Thanks for the feedback. I removed the extra whitespace at the line you mentioned and in another instance further down.

In D40747#927028, @delphij wrote:

Most of the $()'s should be quoted too, since you are already there, maybe get the script through shellcheck?

Thanks for the grammar hint. Fixed.

Fix spelling of descendant.

OK for the manpages part. Thanks.

Approved, thanks!

Updated diff addressing @bsdimp's comments. I changed the "$var"/"something" to "$var/something" to make it easier to read. When required, I can also wrap those variables to be ${var} if necessary.

Alright, I can provide a diff that does that. Makes it easier to read. I'll update this revision when it's ready.

I've read through it and found noting wrong with it.
Great work. I think this will make it more visible to people when it is part of the Primer.

@gbe: Did you have time to work on this yet? Let me know if you need some help finishing this.

Amazing work, this will definitely be helpful to have in the Primer instead of the wiki. Thanks for your work.
I've added a few minor fixes and suggestions.

What is the status of this? Is anyone still working on it?
A lot of people comment on this table still needing improvements.

Overcome by events, less critical these days.

Looks good, both the German and English versions. Much appreciated!

Looks good. I'm also OK with removing the sentence you mentioned.

OK from manpages. Bump the .Dd for this content change when you commit it.
Thank you!

Can we get an update on the status of this review?

Resign from this change. We would have to re-implement it in AsciiDoctor anyway these days.

Overcome by events (DocBook XML migration, mentee timeout).

OK from manpages. Please bump the .Dd when committing.

Any updates here? I'd be happy to approve the man page change.

There is now a port committed as sysutils/hammer2, based on work done in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267982 .
I think we can safely close this review.

Any update on this?

Remove core-team, as we do not seem to get involved in this.

Remove core-team, as we do not need to get involved.
Would still like to see someone commit this...

@carlavilla: Does that look correct to you?

OK for the man page part.

OK from manpages.

Any update on this?

OK for the manpage part of the change.

Looks good, thanks for making the changes.

OK from docs (that's a separate group for doc reviews like this).

@0mp: Can you commit this?

Phew, big change to go through. I did not see anything that needs changing, so go ahead with the commit.
Thank you!

Alright, makes sense to me. Make a note of the decision in the commit message so that we have a track record of the decision.
It's documented in this review description, but a few words of explanation in the message itself should suffice.

Looks good to me. Definitely good to have, thanks!

A couple of minor corrections and additions. It's good to have this documented in the FDP, thanks!

Looks reasonable, approved!

@woodsb02: Are you working on a newer patch for dhcpcd-10 for inclusion into FreeBSD14?
Would really be great to have. If this needs any shepherding from core, I'll see what I can do.

Looks good and would be good to have. Approved!

Looks good to me.

Excellent, more eyes catch more bugs.
Good work, approved also by me!

Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).

Looks good, approved!

Any updates on this?

Looks good to me now.

Looks good to me, definitely useful to have.

Looks good for the doc side of things.

Sure, go ahead!

Excellent, nothing to complain about. Good work, ready to commit!

A few minor language fixes, the rest looks good to me.
Good to have these instructions, thanks for writing them down.

OK for the documentation side of things.
Thanks for your help with the release notes!

Looks good. Don't forget the .Dd bump.

OK from manpages.

OK from manpages.

Found a few minor nits.
We should definitely recommend people to use GPT over MBR.

OK for the man page part of the change.

A few small corrections, the rest looks OK to me.
Good to have a TEX section in the porters handbook with this change!

Looks good, approved for commit!

Can someone commit this? Thanks!

Looks good to me.

Good catch, I'll take care of it.
Thank you!

A few minor edits to the text: one missing word the others are suggestions only.

Looks good. Thank you for your continued work on all things NFS.

OK from manpages for these latest changes. Thanks for your patience working on this patch!

About the use of "you".

Looks good!

Quick question: some of the if-statements here are wrapping the check into [], while others do not.
Do we have some kind of style-guide for shell scripts like this for consistency?
Nothing against the change per se, just wondering.

Looks good, ready to commit!