Page MenuHomeFreeBSD

p_candebug(9): cr_bsd_visible() impacts, misc fixes
ClosedPublic

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 1:52 AM
Unknown Object (File)
Wed, Nov 27, 6:45 PM
Unknown Object (File)
Wed, Nov 27, 6:43 PM
Unknown Object (File)
Wed, Nov 27, 6:42 PM
Unknown Object (File)
Wed, Nov 27, 6:42 PM
Unknown Object (File)
Wed, Nov 27, 6:18 PM
Unknown Object (File)
Mon, Nov 25, 6:35 PM
Unknown Object (File)
Sat, Nov 23, 12:14 AM

Details

Summary

Mention cr_bsd_visible(9). Remove references to cr_canseeothergids(9) and
cr_canseeotheruids(9), as well as indirect references not immediately useful.

Fix description of credentials checks to match reality.

Re-order errors to match code's check order.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Jun 20 2023, 1:45 PM
bcr added inline comments.
share/man/man9/p_candebug.9
76

missing a comma here at the end?

share/man/man9/p_candebug.9
76

Not sure I understand. Are you suggesting:

An unprivileged process attempted to debug another process**,** but the system is

? But if you really mean after deny it, then a priori I don't think so since these words are followed by a parenthetical clause and a dot after it.

Additional active tense substitution, expand contraction

Minor nit, fixable on commit.

share/man/man9/p_candebug.9
60

; instead of , before see

olce marked an inline comment as done.Jun 30 2023, 8:41 AM
This revision is now accepted and ready to land.Jun 30 2023, 10:11 PM
olce retitled this revision from p_candebug(9): cr_bsd_visibility() impacts, misc fixes to p_candebug(9): cr_bsd_visible() impacts, misc fixes.
olce edited the summary of this revision. (Show Details)

Rename cr_bsd_visibility() to cr_bsd_visible().

This revision now requires review to proceed.Jul 14 2023, 10:33 AM

Last changes are just the rename: cr_bsd_visibility() to cr_bsd_visible(). So, revalidating.

This revision is now accepted and ready to land.Jul 14 2023, 10:37 AM
olce edited the summary of this revision. (Show Details)

'cr_see*' => 'cr_cansee*' (suppressed a rename in the stack).

This revision now requires review to proceed.Jul 20 2023, 10:29 AM

Impacts of (suppressing) the rename, so re-validating.

This revision is now accepted and ready to land.Jul 20 2023, 10:30 AM
This revision was automatically updated to reflect the committed changes.