Page MenuHomeFreeBSD
Differential D40638

p_candebug(9): cr_bsd_visible() impacts, misc fixes
ClosedPublic
Actions

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 8:11 PM
Unknown Object (File)
Sun, May 12, 2:23 PM
Unknown Object (File)
Wed, May 1, 6:52 AM
Unknown Object (File)
Sat, Apr 27, 2:35 AM
Unknown Object (File)
Tue, Apr 23, 9:16 AM
Unknown Object (File)
Apr 18 2024, 10:49 PM
Unknown Object (File)
Apr 14 2024, 12:04 PM
Unknown Object (File)
Feb 2 2024, 8:37 PM
View All 25 Files
Subscribers
bcr
emaste
imp
pauamma_gundo.com
manpages

Details

Reviewers
mjg
kib
dchagin
pauamma_gundo.com
olce
Commits
rG6345a69ee271: p_candebug(9): cr_bsd_visible() impacts, misc fixes
rGdaf8ad192942: p_candebug(9): cr_bsd_visible() impacts, misc fixes
rG76781950658c: p_candebug(9): cr_bsd_visible() impacts, misc fixes
rGeb94f24fab4b: p_candebug(9): cr_bsd_visible() impacts, misc fixes
Summary

Mention cr_bsd_visible(9). Remove references to cr_canseeothergids(9) and
cr_canseeotheruids(9), as well as indirect references not immediately useful.

Fix description of credentials checks to match reality.

Re-order errors to match code's check order.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Jun 20 2023, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 1:45 PM
olce requested review of this revision.Jun 20 2023, 1:45 PM
Harbormaster completed remote builds in B52173: Diff 123504.Jun 20 2023, 1:45 PM
olce added a parent revision: D40637: p_cansee(9): Bring up-to-date, misc fixes.Jun 20 2023, 2:11 PM
olce added a child revision: D40639: prison_check(9): Bring up-to-date with hierarchical jails.
olce added reviewers: mjg, kib, dchagin.Jun 20 2023, 9:03 PM
emaste added subscribers: manpages, emaste.Jun 29 2023, 3:58 PM
bcr added a subscriber: bcr.Jun 29 2023, 4:05 PM
bcr added inline comments.
share/man/man9/p_candebug.9
76

missing a comma here at the end?

olce added inline comments.Jun 29 2023, 7:28 PM
share/man/man9/p_candebug.9
76

Not sure I understand. Are you suggesting:

An unprivileged process attempted to debug another process**,** but the system is

? But if you really mean after deny it, then a priori I don't think so since these words are followed by a parenthetical clause and a dot after it.

olce updated this revision to Diff 124013.Jun 29 2023, 9:14 PM

Additional active tense substitution, expand contraction

Harbormaster completed remote builds in B52350: Diff 124013.Jun 29 2023, 9:14 PM
olce updated this revision to Diff 124014.Jun 29 2023, 9:15 PM

Good diff instead.

Harbormaster completed remote builds in B52351: Diff 124014.Jun 29 2023, 9:15 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Jun 29 2023, 9:56 PM

Minor nit, fixable on commit.

share/man/man9/p_candebug.9
60
olce updated this revision to Diff 124027.Jun 30 2023, 8:40 AM

; instead of , before see

Harbormaster completed remote builds in B52357: Diff 124027.Jun 30 2023, 8:40 AM
olce marked an inline comment as done.Jun 30 2023, 8:41 AM
pauamma_gundo.com accepted this revision.Jun 30 2023, 10:11 PM
This revision is now accepted and ready to land.Jun 30 2023, 10:11 PM
olce updated this revision to Diff 124671.Jul 14 2023, 10:33 AM
olce retitled this revision from p_candebug(9): cr_bsd_visibility() impacts, misc fixes to p_candebug(9): cr_bsd_visible() impacts, misc fixes.
olce edited the summary of this revision. (Show Details)

Rename cr_bsd_visibility() to cr_bsd_visible().

This revision now requires review to proceed.Jul 14 2023, 10:33 AM
Harbormaster completed remote builds in B52648: Diff 124671.Jul 14 2023, 10:33 AM
olce accepted this revision.Jul 14 2023, 10:37 AM

Last changes are just the rename: cr_bsd_visibility() to cr_bsd_visible(). So, revalidating.

This revision is now accepted and ready to land.Jul 14 2023, 10:37 AM
olce updated this revision to Diff 124902.Jul 20 2023, 10:29 AM
olce edited the summary of this revision. (Show Details)

'cr_see*' => 'cr_cansee*' (suppressed a rename in the stack).

This revision now requires review to proceed.Jul 20 2023, 10:29 AM
Harbormaster completed remote builds in B52739: Diff 124902.Jul 20 2023, 10:29 AM
olce accepted this revision.Jul 20 2023, 10:30 AM

Impacts of (suppressing) the rename, so re-validating.

This revision is now accepted and ready to land.Jul 20 2023, 10:30 AM
Closed by commit rGeb94f24fab4b: p_candebug(9): cr_bsd_visible() impacts, misc fixes (authored by olce, committed by mhorne). · Explain WhySep 28 2023, 3:12 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rGeb94f24fab4b: p_candebug(9): cr_bsd_visible() impacts, misc fixes.
mhorne added a commit: rG76781950658c: p_candebug(9): cr_bsd_visible() impacts, misc fixes.Oct 17 2023, 7:44 PM
mhorne added a commit: rGdaf8ad192942: p_candebug(9): cr_bsd_visible() impacts, misc fixes.Oct 18 2023, 6:04 PM
olce added a commit: rG6345a69ee271: p_candebug(9): cr_bsd_visible() impacts, misc fixes.Dec 21 2023, 1:46 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
103 lines

Diff 127921

View Options

share/man/man9/p_candebug.9

Loading...