Page MenuHomeFreeBSD
Differential D40634

groupmember(9): Detail which groups are considered, simplify
ClosedPublic
Actions

Authored by olce on Jun 20 2023, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 6:24 PM
Unknown Object (File)
Sun, Nov 24, 1:09 PM
Unknown Object (File)
Sun, Nov 24, 4:55 AM
Unknown Object (File)
Sat, Nov 23, 4:30 AM
Unknown Object (File)
Wed, Nov 20, 12:47 AM
Unknown Object (File)
Mon, Nov 18, 10:07 PM
Unknown Object (File)
Sun, Nov 17, 5:52 PM
Unknown Object (File)
Sat, Nov 16, 11:32 PM
View All 79 Files
Subscribers
imp
mhorne

Details

Reviewers
mjg
kib
dchagin
mhorne
Commits
rGd23893ca4dd0: groupmember(9): Detail which groups are considered, simplify
rG7dd1f9f9c949: groupmember(9): Detail which groups are considered, simplify
rG60cc4f16d4e9: groupmember(9): Detail which groups are considered, simplify
rG75a45ca3b340: groupmember(9): Detail which groups are considered, simplify

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Jun 20 2023, 1:44 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 1:44 PM
olce requested review of this revision.Jun 20 2023, 1:44 PM
Harbormaster completed remote builds in B52169: Diff 123500.Jun 20 2023, 1:45 PM
olce added a parent revision: D40633: cr_canseeothergids(9): Revamp, mark as internal.Jun 20 2023, 2:11 PM
olce added a child revision: D40635: cr_canseeotheruids(9): Revamp, mark as internal.
olce added reviewers: mjg, kib, dchagin.Jun 20 2023, 9:03 PM
olce updated this revision to Diff 124009.Jun 29 2023, 8:57 PM

New sentence on new line.

Harbormaster completed remote builds in B52346: Diff 124009.Jun 29 2023, 8:58 PM
mhorne mentioned this in D39129: groupmember.9: remove the man page.Jul 7 2023, 3:46 PM
mhorne accepted this revision.Jul 7 2023, 3:52 PM
mhorne added a subscriber: mhorne.

LGTM

share/man/man9/groupmember.9
55–58

You could consider changing the return value to a bool type, perhaps as a follow-up.

56–57

Drop this if you end up merging the two pages, as I suggested in the realgroupmember(9) review.

This revision is now accepted and ready to land.Jul 7 2023, 3:52 PM
olce updated this revision to Diff 124439.Jul 10 2023, 3:36 PM

Remove ref to realgroupmember(9). Add refs to remotely-related system calls.

This revision now requires review to proceed.Jul 10 2023, 3:36 PM
Harbormaster completed remote builds in B52542: Diff 124439.Jul 10 2023, 3:36 PM
olce marked 2 inline comments as done.Jul 10 2023, 3:36 PM
olce added inline comments.
share/man/man9/groupmember.9
55–58

This is going to be addressed as a follow-up.

olce marked an inline comment as done.Jul 10 2023, 3:44 PM

FYI, I've changed the short description, that's why I didn't put this differential as "Ready to land." again. If someone could check it...

mhorne accepted this revision.Jul 24 2023, 6:10 PM
This revision is now accepted and ready to land.Jul 24 2023, 6:10 PM
Closed by commit rG75a45ca3b340: groupmember(9): Detail which groups are considered, simplify (authored by olce, committed by mhorne). · Explain WhySep 28 2023, 3:12 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG75a45ca3b340: groupmember(9): Detail which groups are considered, simplify.
mhorne added a commit: rG60cc4f16d4e9: groupmember(9): Detail which groups are considered, simplify.Oct 17 2023, 7:44 PM
mhorne added a commit: rG7dd1f9f9c949: groupmember(9): Detail which groups are considered, simplify.Oct 18 2023, 6:04 PM
olce added a commit: rGd23893ca4dd0: groupmember(9): Detail which groups are considered, simplify.Dec 21 2023, 1:46 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
36 lines

Diff 127916

View Options

share/man/man9/groupmember.9

Loading...