Page MenuHomeFreeBSD
Differential D40643

realgroupmember(9): Link to groupmember(9), document the function
ClosedPublic
Actions

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 31, 10:10 AM
Unknown Object (File)
Sat, Jan 31, 4:50 AM
Unknown Object (File)
Fri, Jan 30, 4:24 AM
Unknown Object (File)
Thu, Jan 29, 9:06 PM
Unknown Object (File)
Thu, Jan 29, 7:17 PM
Unknown Object (File)
Thu, Jan 29, 5:43 AM
Unknown Object (File)
Thu, Jan 29, 4:30 AM
Unknown Object (File)
Sun, Jan 25, 3:29 AM
View All Files
Subscribers
bcr
emaste
imp
mhorne
manpages

Details

Reviewers
mjg
kib
dchagin
bcr
mhorne
Commits
rG3eb8bf041831: realgroupmember(9): Link to groupmember(9), document the function
rG5d9f38405a10: realgroupmember(9): Link to groupmember(9), document the function

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Jun 20 2023, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 1:45 PM
olce requested review of this revision.Jun 20 2023, 1:45 PM
Harbormaster completed remote builds in B52178: Diff 123509.Jun 20 2023, 1:45 PM
olce added a parent revision: D40642: cr_canseeothergids(): Use real instead of effective group membership.Jun 20 2023, 2:11 PM
olce added a child revision: D40644: cr_canseeothergids(): Policy change's manual pages impact.
olce added reviewers: mjg, kib, dchagin.Jun 20 2023, 9:03 PM
emaste added subscribers: manpages, emaste.Jun 29 2023, 4:10 PM

For commit should be part of D40641

bcr added a subscriber: bcr.Jun 29 2023, 4:13 PM
bcr added inline comments.
share/man/man9/realgroupmember.9
51 ↗(On Diff #123509)

A line break is needed here after the sentence stop.

olce updated this revision to Diff 124016.Jun 29 2023, 9:19 PM

New sentence on new line.

Harbormaster completed remote builds in B52353: Diff 124016.Jun 29 2023, 9:19 PM
olce marked an inline comment as done.Jun 29 2023, 9:19 PM
bcr accepted this revision.Jun 30 2023, 7:29 AM

Looks good now, thank you.

This revision is now accepted and ready to land.Jun 30 2023, 7:29 AM
mhorne requested changes to this revision.Jul 7 2023, 3:44 PM
mhorne added a subscriber: mhorne.

I would prefer to see this content added to groupmember(9), instead of creating a new page. The functions are closely related, and having them side-by-side allows easier comparison for the reader.

Add an MLINK entry to share/man/man9/Makefile to create the realgroupmember.9.gz symlink.

This revision now requires changes to proceed.Jul 7 2023, 3:44 PM
olce updated this revision to Diff 124438.Jul 10 2023, 3:27 PM
olce retitled this revision from realgroupmember(9): New man page to realgroupmember(9): Link to groupmember(9), document the function.

Make the "new page" a link to groupmember(9). Update it.

This made me notice also that the function name in the signature was wrong.

Harbormaster completed remote builds in B52541: Diff 124438.Jul 10 2023, 3:27 PM
olce updated this revision to Diff 124440.Jul 10 2023, 3:39 PM

Remove a polluting diff that has been integrated in an earlier differential in the stack.

Harbormaster completed remote builds in B52543: Diff 124440.Jul 10 2023, 3:39 PM
mhorne accepted this revision.Jul 11 2023, 5:03 PM
This revision is now accepted and ready to land.Jul 11 2023, 5:03 PM
Closed by commit rG5d9f38405a10: realgroupmember(9): Link to groupmember(9), document the function (authored by olce, committed by mhorne). · Explain WhySep 28 2023, 3:12 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG5d9f38405a10: realgroupmember(9): Link to groupmember(9), document the function.
mhorne mentioned this in rGd1fde7841f3f: New realgroupmember().Oct 17 2023, 7:44 PM
mhorne mentioned this in rG4750f117a060: New realgroupmember().Oct 18 2023, 6:04 PM
olce added a commit: rG3eb8bf041831: realgroupmember(9): Link to groupmember(9), document the function.Dec 21 2023, 1:46 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
1 line
7 lines

Diff 127926

View Options

share/man/man9/Makefile

Loading...
View Options

share/man/man9/groupmember.9

Loading...