Page MenuHomeFreeBSD

p_cansee(9): Bring up-to-date, misc fixes
ClosedPublic

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 6:24 PM
Unknown Object (File)
Wed, Nov 27, 6:21 PM
Unknown Object (File)
Mon, Nov 25, 1:12 AM
Unknown Object (File)
Sun, Nov 24, 5:05 AM
Unknown Object (File)
Sat, Nov 23, 2:59 AM
Unknown Object (File)
Sat, Nov 23, 12:17 AM
Unknown Object (File)
Fri, Nov 22, 8:33 AM
Unknown Object (File)
Wed, Nov 20, 1:10 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Jun 20 2023, 1:45 PM

Suggestion to simplify sentence at bit.

share/man/man9/p_cansee.9
48

s/even in the face of pending/even when pending/

Fixes prompted by the comments.

share/man/man9/p_cansee.9
48

I had forgotten an "s" to "change" and I think this mislead you to think "change" was a verb, did it?

Other than bcr's suggestion, English LGTM.

share/man/man9/p_cansee.9
48

No, bcr's suggestion (which I agree with) only makes sense if "change(s)" is a noun. For it to be a verb, I'd expect something like "even if credentials are about to change" instead.

share/man/man9/p_cansee.9
48

So IIUC here is the full sentence you're proposing (with the following parentheses):

This function explicitly allows a thread to always see its own process, even when pending credentials changes (see ucred(9)).

FWIW, to me, the proposition after the comma is incorrect. I've never seen the form "even when" + noun and without a verb. Reading it, I would interpret "changes" as a verb (with a superfluous "s"). But then I'm not a native speaker, so please educate me if I'm wrong.

So, to dispel any doubts and for my own sake, do you confirm the above quotation of the full sentence is what you'd like?

share/man/man9/p_cansee.9
48

In hindsight, I think I misread "when" as "with". See my suggested edit for my preferred text. If you don't go with it, I would still use another wording than "in the face of" which to me (and I suspect many native speakers) would be a bizarre image. Perhaps "in the presence of"?

share/man/man9/p_cansee.9
48

Not sure what you find bizarre with in the face of. Anyway, using even with is simple, shorter, and conveys the same meaning (almost), so let's go with it.

olce marked 3 inline comments as done.Jul 2 2023, 10:56 AM
This revision is now accepted and ready to land.Jul 3 2023, 2:17 AM
This revision was automatically updated to reflect the committed changes.