Page MenuHomeFreeBSD

p_candebug(9): cr_bsd_visible() impacts, misc fixes
ClosedPublic

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
F86115776: D40638.diff
Sat, Jun 15, 5:03 PM
Unknown Object (File)
Fri, Jun 14, 2:06 AM
Unknown Object (File)
May 13 2024, 8:11 PM
Unknown Object (File)
May 12 2024, 2:23 PM
Unknown Object (File)
May 1 2024, 6:52 AM
Unknown Object (File)
Apr 27 2024, 2:35 AM
Unknown Object (File)
Apr 23 2024, 9:16 AM
Unknown Object (File)
Apr 18 2024, 10:49 PM

Details

Summary

Mention cr_bsd_visible(9). Remove references to cr_canseeothergids(9) and
cr_canseeotheruids(9), as well as indirect references not immediately useful.

Fix description of credentials checks to match reality.

Re-order errors to match code's check order.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52357
Build 49248: arc lint + arc unit

Event Timeline

olce requested review of this revision.Jun 20 2023, 1:45 PM
bcr added inline comments.
share/man/man9/p_candebug.9
79

missing a comma here at the end?

share/man/man9/p_candebug.9
79

Not sure I understand. Are you suggesting:

An unprivileged process attempted to debug another process**,** but the system is

? But if you really mean after deny it, then a priori I don't think so since these words are followed by a parenthetical clause and a dot after it.

Additional active tense substitution, expand contraction

Minor nit, fixable on commit.

share/man/man9/p_candebug.9
62

; instead of , before see

olce marked an inline comment as done.Jun 30 2023, 8:41 AM
This revision is now accepted and ready to land.Jun 30 2023, 10:11 PM
olce retitled this revision from p_candebug(9): cr_bsd_visibility() impacts, misc fixes to p_candebug(9): cr_bsd_visible() impacts, misc fixes.
olce edited the summary of this revision. (Show Details)

Rename cr_bsd_visibility() to cr_bsd_visible().

This revision now requires review to proceed.Jul 14 2023, 10:33 AM

Last changes are just the rename: cr_bsd_visibility() to cr_bsd_visible(). So, revalidating.

This revision is now accepted and ready to land.Jul 14 2023, 10:37 AM
olce edited the summary of this revision. (Show Details)

'cr_see*' => 'cr_cansee*' (suppressed a rename in the stack).

This revision now requires review to proceed.Jul 20 2023, 10:29 AM

Impacts of (suppressing) the rename, so re-validating.

This revision is now accepted and ready to land.Jul 20 2023, 10:30 AM
This revision was automatically updated to reflect the committed changes.