Page MenuHomeFreeBSD

committers-doc.dot: bring file up to date
ClosedPublic

Authored by fernape on Mar 29 2023, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 5:35 AM
Unknown Object (File)
Nov 28 2023, 12:24 PM
Unknown Object (File)
Nov 8 2023, 7:42 PM
Unknown Object (File)
Nov 8 2023, 3:13 AM
Unknown Object (File)
Nov 5 2023, 5:40 PM
Unknown Object (File)
Nov 5 2023, 4:57 PM
Unknown Object (File)
Oct 30 2023, 7:50 AM
Unknown Object (File)
Oct 7 2023, 6:41 PM
Subscribers

Details

Summary

This file was terribly outdated. If this is something we want, and this review is accepted I will do the same for ports and src.

Test Plan

This is difficult to test, but apply the patch and run:

dot -T png -o file.png committers-doc.dot

The generated file can be seen here

What I did was to take the current value of internal/admin/access for the doc
repository, do some grep -v to get the people who don't have access anymore
and then dig a bit the output of git log.

Note that I am unable to find when the commit bit for jim@ was taking in.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape edited the summary of this revision. (Show Details)
fernape added reviewers: doceng, docs.

Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).

share/misc/committers-doc.dot
64

s/salvadore[label/salvadore [label/

90–91

s/Apesteguia\fernape/Apesteguia\nfernape/

(\n missing)

Fix a couple of issues spotted by bcr@

This revision is now accepted and ready to land.Mar 29 2023, 4:38 PM
share/misc/committers-doc.dot
64

Actually I fixed this line and mistakenly moved salvadore@ to the alumni group :-S

Thanks a lot for this careful review.

90–91

Thanks!

Excellent, more eyes catch more bugs.
Good work, approved also by me!

This revision was automatically updated to reflect the committed changes.