Page MenuHomeFreeBSD
Differential D39309

committers-doc.dot: bring file up to date
ClosedPublic
Actions

Authored by fernape on Mar 29 2023, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 4:42 AM
Unknown Object (File)
Sat, Apr 27, 7:29 AM
Unknown Object (File)
Sat, Apr 27, 7:23 AM
Unknown Object (File)
Sat, Apr 27, 7:23 AM
Unknown Object (File)
Sat, Apr 27, 7:23 AM
Unknown Object (File)
Sat, Apr 27, 5:27 AM
Unknown Object (File)
Dec 23 2023, 5:35 AM
Unknown Object (File)
Nov 28 2023, 12:24 PM
View All 23 Files
Subscribers
bcr
imp

Details

Reviewers
carlavilla
bcr
Group Reviewers
doceng
docs
Commits
rG52f576459855: committers-doc.dot: bring file up to date
Summary

This file was terribly outdated. If this is something we want, and this review is accepted I will do the same for ports and src.

Test Plan

This is difficult to test, but apply the patch and run:

dot -T png -o file.png committers-doc.dot

The generated file can be seen here

What I did was to take the current value of internal/admin/access for the doc
repository, do some grep -v to get the people who don't have access anymore
and then dig a bit the output of git log.

Note that I am unable to find when the commit bit for jim@ was taking in.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50656
Build 47547: arc lint + arc unit

Event Timeline

fernape created this revision.Mar 29 2023, 9:12 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 29 2023, 9:12 AM
fernape requested review of this revision.Mar 29 2023, 9:12 AM
Harbormaster completed remote builds in B50638: Diff 119595.Mar 29 2023, 9:12 AM
fernape edited the test plan for this revision. (Show Details)Mar 29 2023, 9:13 AM
fernape edited the summary of this revision. (Show Details)
fernape added reviewers: doceng, docs.
bcr added a subscriber: bcr.Mar 29 2023, 3:48 PM

Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).

share/misc/committers-doc.dot
64

s/salvadore[label/salvadore [label/

90–91

s/Apesteguia\fernape/Apesteguia\nfernape/

(\n missing)

fernape updated this revision to Diff 119620.Mar 29 2023, 4:37 PM

Fix a couple of issues spotted by bcr@

Harbormaster completed remote builds in B50656: Diff 119620.Mar 29 2023, 4:37 PM
carlavilla accepted this revision as: docs, carlavilla.Mar 29 2023, 4:38 PM
This revision is now accepted and ready to land.Mar 29 2023, 4:38 PM
fernape added inline comments.Mar 29 2023, 4:42 PM
share/misc/committers-doc.dot
64

Actually I fixed this line and mistakenly moved salvadore@ to the alumni group :-S

Thanks a lot for this careful review.

90–91

Thanks!

bcr accepted this revision as: bcr.Mar 29 2023, 5:54 PM

Excellent, more eyes catch more bugs.
Good work, approved also by me!

Closed by commit rG52f576459855: committers-doc.dot: bring file up to date (authored by fernape). · Explain WhyMar 30 2023, 7:54 AM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG52f576459855: committers-doc.dot: bring file up to date.

Revision Contents
Changeset List

PathSize
share/
misc/
54 lines

Diff 119620

View Options

share/misc/committers-doc.dot

Loading...