Page MenuHomeFreeBSD

Fix some shell issues by adding quotes in fwget.sh
ClosedPublic

Authored by bcr on Jun 19 2023, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 18, 7:52 AM
Unknown Object (File)
Fri, Jun 26, 7:24 PM
Unknown Object (File)
Thu, Jun 25, 1:18 AM
Unknown Object (File)
Jun 8 2026, 8:55 AM
Unknown Object (File)
May 18 2026, 1:54 AM
Unknown Object (File)
May 18 2026, 1:54 AM
Unknown Object (File)
May 18 2026, 1:45 AM
Unknown Object (File)
May 6 2026, 1:46 AM
Subscribers

Details

Summary

This patch fixes the following issues in the shell script:

  • Quote default assignments, see SC2223
  • Use $() instead of backticks, see SC2006
  • Double quote $@, see SC2068
  • Double quote variables in if-statements and other places, see SC2086

While here, fix a whitespace at end of line instance in the license text.

Test Plan
  1. Apply the patch to /usr.sbin/fwget
  2. Run fwget to see if it still works

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable