Page MenuHomeFreeBSD
Differential D40133

Add nss_tacplus, a TACACS+ NSS module.
ClosedPublic
Actions

Authored by des on May 17 2023, 12:09 PM.
Tags
None
Referenced Files
F171384520: D40133.id122039.diff
Thu, Sep 10, 8:23 PM
F171383919: D40133.id122045.diff
Thu, Sep 10, 8:18 PM
Unknown Object (File)
Tue, Sep 8, 3:41 PM
Unknown Object (File)
Sun, Sep 6, 10:27 AM
Unknown Object (File)
Sun, Sep 6, 6:53 AM
Unknown Object (File)
Sun, Sep 6, 4:43 AM
Unknown Object (File)
Sun, Sep 6, 3:57 AM
Unknown Object (File)
Sat, Sep 5, 11:24 PM
View All Files
Subscribers
bcr
imp

Details

Reviewers
imp
Group Reviewers
Klara
manpages
Commits
rG96fabd5cbc32: Add nss_tacplus, a TACACS+ NSS module.
rG6c5cdba1bafe: Add nss_tacplus, a TACACS+ NSS module.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.May 17 2023, 12:09 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 17 2023, 12:09 PM
des requested review of this revision.May 17 2023, 12:09 PM
Harbormaster completed remote builds in B51524: Diff 122039.May 17 2023, 12:10 PM
des added a parent revision: D40132: taclib: 0 (not set) is a valid auth type in authorization requests..May 17 2023, 12:10 PM
des added a reviewer: manpages.May 17 2023, 12:10 PM
bcr accepted this revision as: manpages.May 17 2023, 1:09 PM
bcr added a subscriber: bcr.

OK for the manpage part of the change.

des updated this revision to Diff 122045.May 17 2023, 1:50 PM

Fix type issue.

Harbormaster completed remote builds in B51525: Diff 122045.May 17 2023, 1:50 PM
imp accepted this revision.May 17 2023, 2:00 PM

The build stuff looks good, the man page is good...
the code is good for my scan, but I didn't look in detail. None of my 'hot button' issues are in the code.

lib/nss_tacplus/Makefile
5

Why do you need this? Is it because there's no lib in front?

This revision is now accepted and ready to land.May 17 2023, 2:00 PM
des marked an inline comment as done.May 17 2023, 2:13 PM
des added inline comments.
lib/nss_tacplus/Makefile
5

Correct, without this line it would be installed as libnss_tacplus.so.1 and nsdispatch wouldn't find it.

des marked an inline comment as done.May 17 2023, 2:13 PM
des added a child revision: D40135: pam_tacplus: Mention nss_tacplus in the manual page..May 17 2023, 2:19 PM
Closed by commit rG6c5cdba1bafe: Add nss_tacplus, a TACACS+ NSS module. (authored by des). · Explain WhyMay 22 2023, 10:45 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG6c5cdba1bafe: Add nss_tacplus, a TACACS+ NSS module..
des added a commit: rG96fabd5cbc32: Add nss_tacplus, a TACACS+ NSS module..Dec 13 2023, 8:07 PM

Revision Contents
Changeset List

PathSize
lib/
4 lines
nss_tacplus/
9 lines
86 lines
273 lines

Diff 122205

View Options

lib/Makefile

Loading...
View Options

lib/nss_tacplus/Makefile

Loading...
View Options

lib/nss_tacplus/nss_tacplus.8

Loading...
View Options

lib/nss_tacplus/nss_tacplus.c

Loading...