ping: Accept ToS keywords with -z

[jlduran_gmail.com]

Summary

Inspired by: OpenBSD/Darwin
Obtained from: pfctl/parse.y (src), pf.conf.5 (man)

[jlduran_gmail.com]

As a courtesy, tag @kp, as this code was mostly stolen from him.

[pauamma_gundo.com]

sbin/ping/ping.8

437

Reading this, I would be confused by the difference if any between "netcontrol" and "inetcontrol" and which to use when.

440

Audience check: would people reading this be familiar with the "DiffServ" abbreviation? (I assume it stands for "Differentiated Services".)

441–444

I'd add a "see also" for the meaning of those.

[jlduran_gmail.com]

Thank you @pauamma! Those are great suggestions. I took man page changes from pf.conf.5, so I consider it to be my "upstream".
How about a change there, and then pull in those changes here?

sbin/ping/ping.8

437

I'm afraid I won't be able to change the name, as the idea is to mimic pf.conf(5), but we can detail what it means, as ipfw(8) does.
There are a few reasons why I chose pf's implementation, the chief ones being:

1. This code was inspired by OpenBSD.
2. IPFW was missing the va code point, which I submitted not so long ago, and this patch was prepared before the addition was made.

[pauamma_gundo.com]

In D38490#876182, @jlduran_gmail.com wrote:

Thank you @pauamma! Those are great suggestions. I took man page changes from pf.conf.5, so I consider it to be my "upstream".
How about a change there, and then pull in those changes here?

Sounds good to me, in either direction.

[bcr]

Any updates here? I'd be happy to approve the man page change.

[jlduran_gmail.com]

In D38490#914771, @bcr wrote:

Any updates here? I'd be happy to approve the man page change.

Sorry, I have not worked on the man page changes. I was waiting on the code review/approval first. I'll add @kp as a reviewer directly.

Thank you for reminding me about it!