Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 27, 6:47 PM

	Unknown Object (File)
	Thu, May 23, 10:51 AM

	Unknown Object (File)
	Wed, May 22, 10:06 PM

	Unknown Object (File)
	Wed, May 22, 8:31 PM

	Unknown Object (File)
	Mar 8 2024, 8:30 PM

	Unknown Object (File)
	Mar 8 2024, 4:07 AM

	Unknown Object (File)
	Mar 8 2024, 3:44 AM

	Unknown Object (File)
	Mar 8 2024, 3:44 AM

View All 32 Files

Subscribers

imp

Contributor Reviews (src)

Details

Reviewers

markj
asomers

Group Reviewers

network

Commits

rG3c7ef29e8998: ping: Avoid magic numbers
rG491263d7a640: ping: Avoid magic numbers

Summary

The sizeof(struct ip) is 20.
The sizeof(struct in_addr) is 4.
No functional change intended.

Test Plan

kyua test -k /usr/tests/Kyuafile sbin/ping/ping_test
kyua test -k /usr/tests/Kyuafile sbin/ping/test_ping.py

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran_gmail.com created this revision.Mar 16 2023, 4:35 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2023, 4:35 PM

jlduran_gmail.com requested review of this revision.Mar 16 2023, 4:35 PM

jlduran_gmail.com added a child revision: D38469: ping: Print the IP options of the original packet.

asomers accepted this revision.Mar 16 2023, 5:02 PM

This revision is now accepted and ready to land.Mar 16 2023, 5:02 PM

jlduran_gmail.com mentioned this in D38469: ping: Print the IP options of the original packet.Mar 16 2023, 6:11 PM

Closed by commit rG491263d7a640: ping: Avoid magic numbers (authored by jlduran_gmail.com, committed by markj). · Explain WhyMar 17 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG491263d7a640: ping: Avoid magic numbers.

markj added a commit: rG3c7ef29e8998: ping: Avoid magic numbers.Mar 24 2023, 4:59 PM

ping: Avoid magic numbers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 119010

sbin/ping/ping.c

ping: Avoid magic numbersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 119010

sbin/ping/ping.c

ping: Avoid magic numbers
ClosedPublic
Actions

Revision Contents
Changeset List