Page MenuHomeFreeBSD

Add quotes to zzz.sh and replace legacy backticks with $()
ClosedPublic

Authored by bcr on Jun 23 2023, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 3, 12:56 AM
Unknown Object (File)
Wed, Apr 29, 1:11 PM
Unknown Object (File)
Tue, Apr 28, 1:03 AM
Unknown Object (File)
Mon, Apr 27, 7:09 PM
Unknown Object (File)
Mon, Apr 27, 5:09 AM
Unknown Object (File)
Sat, Apr 25, 10:33 PM
Unknown Object (File)
Sat, Apr 25, 8:08 AM
Unknown Object (File)
Fri, Apr 24, 9:27 PM
Subscribers

Details

Summary

This patch does the following:

  • Replaces legacy backticks with $()
  • Quote strings to prevent word splitting
Test Plan

The changes should not affect the code execution, but I found no tests for zzz that I could run.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcr requested review of this revision.Jun 23 2023, 4:55 PM
usr.sbin/zzz/zzz.sh
21

You can kill the space before the ).

Thanks for the feedback. I removed the extra whitespace at the line you mentioned and in another instance further down.

bcr marked an inline comment as done.Jun 27 2023, 7:03 AM

I'm bothered by the pre existing echo grep pair.
But these cleanups do make the code marginally better...

This revision is now accepted and ready to land.Jun 27 2023, 12:55 PM