Page MenuHomeFreeBSD

Add quotes to zzz.sh and replace legacy backticks with $()
ClosedPublic

Authored by bcr on Jun 23 2023, 4:55 PM.
Tags
None
Referenced Files
F104095683: D40726.diff
Tue, Dec 3, 12:11 PM
F104025448: D40726.id123808.diff
Mon, Dec 2, 1:51 PM
F104024942: D40726.diff
Mon, Dec 2, 1:42 PM
Unknown Object (File)
Thu, Nov 21, 10:45 PM
Unknown Object (File)
Sun, Nov 17, 4:59 PM
Unknown Object (File)
Sun, Nov 17, 12:42 PM
Unknown Object (File)
Oct 5 2024, 7:49 PM
Unknown Object (File)
Oct 5 2024, 4:08 AM
Subscribers

Details

Summary

This patch does the following:

  • Replaces legacy backticks with $()
  • Quote strings to prevent word splitting
Test Plan

The changes should not affect the code execution, but I found no tests for zzz that I could run.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcr requested review of this revision.Jun 23 2023, 4:55 PM
usr.sbin/zzz/zzz.sh
21

You can kill the space before the ).

Thanks for the feedback. I removed the extra whitespace at the line you mentioned and in another instance further down.

bcr marked an inline comment as done.Jun 27 2023, 7:03 AM

I'm bothered by the pre existing echo grep pair.
But these cleanups do make the code marginally better...

This revision is now accepted and ready to land.Jun 27 2023, 12:55 PM