Page MenuHomeFreeBSD

Minor adjustments to embed_dtb.sh and make_dtbh.sh
Needs ReviewPublic

Authored by bcr on Jun 29 2023, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 9:23 PM
Unknown Object (File)
Jan 10 2024, 1:59 AM
Unknown Object (File)
Dec 21 2023, 10:35 AM
Unknown Object (File)
Dec 12 2023, 11:42 AM
Unknown Object (File)
Dec 5 2023, 12:52 PM
Unknown Object (File)
Oct 8 2023, 10:58 PM
Unknown Object (File)
Sep 22 2023, 11:58 AM
Unknown Object (File)
Aug 21 2023, 10:16 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Src Committers
Summary

This patch does the following:

embed_dtb.sh:

  • Instead of using ls -l and parsing the output simply to get the file size, use stat(1) to get it. The ls output is intended for human consumption and may differ depending on the execution environment (i.e. human readable numbers).
  • Replace backticks with $()
  • Replace $var with ${var}
  • Double quote vars to prevent word splits and globbing

make_dtbh.sh:

  • Replace backticks with $()
  • Replace $var with ${var}
  • Double quote vars to prevent word splits and globbing
Test Plan

Run the scripts (especially embed_dtb.sh for the new way to determine the filesize) and check the result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bcr requested review of this revision.Jun 29 2023, 1:21 PM
bcr edited the summary of this revision. (Show Details)