LGMT too. Thanks!

It bugs me to have new, BSD licensed, code in the cddl directory but I'm OK with this being there for now. And, yes, we need an automagic way to generate these.

LGTM

Sure.

This has already been committed upstream and is present in HEAD.

Address markj's comments.

The Transport group discussed this during a conference call and decided that this is good to go in.

Other than the two minor nits above this looks OK to me.

I like the use of DTrace as well. Please add the script as another commit.

Note that this has failed to build according to the build bot (see Harbormaster). Thoughts on that?

Other than the need for some clarifying parentheses I think this is OK.

Looks like Jenkins didn't like this little change either. You should look into the build failure. I also agree with the removal of _all() from the function name.

Other than the nits I pointed out already this looks like a good change.

Remove filtering based on system call type (suggested by rwatson)

New, BSD license, code does not need to be in cddl. Most of the new D scripts and programs go into either share/dtrace or the DTrace Toolkit port. Since this is a script I'd put it into share/dtrace if you want it in the src tree.

Actually it was in kern_fork() that I first looked, but, we do not have access to the syscall args structure at that point. I'll dig a bit more to see if I missed a pointer that would lead me there, or figure out if there is a reasonable way to synthesize one.

If you can wait a day or so I'd love to have Olivier, now added to the review, run one of his perf tests on this.

Address two of markj's suggestions.

Updated