Page MenuHomeFreeBSD

Fix test timeout: common.funcs.t_dtrace_contrib.tst_cleanpath_d
ClosedPublic

Authored by lwhsu on Jul 20 2017, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 6 2024, 7:39 AM
Unknown Object (File)
Oct 6 2024, 7:39 AM
Unknown Object (File)
Oct 3 2024, 10:47 AM
Unknown Object (File)
Oct 2 2024, 8:27 PM
Unknown Object (File)
Oct 1 2024, 8:17 AM
Unknown Object (File)
Oct 1 2024, 7:08 AM
Unknown Object (File)
Sep 30 2024, 3:33 PM
Unknown Object (File)
Sep 27 2024, 5:09 PM
Subscribers

Details

Summary

We added too many variable assignments in BEGIN block, and out of default auto
configured variable buffer space. The test VM has 4G RAM which should be enough
for most cases so it's reasonable to increase limitation to these cases.

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace && kyua debug common/funcs/t_dtrace_contrib:tst_cleanpath_d

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

LGTM at least, but markj might have some input that needs to be considered here.

Sorry for being picky, but could you paste the output of this test without the change?

Sorry for being picky, but could you paste the output of this test without the change?

There is nothing out stdout, the error messages from kyua are as following:

lwhsu@FreeBSD-12-t:/usr/tests/cddl/usr.sbin/dtrace/common/funcs > sudo kyua debug t_dtrace_contrib:tst_cleanpath_d
Executing command [ /usr/tests/cddl/usr.sbin/dtrace/common/funcs/../../dtest /usr/tests/cddl/usr.sbin/dtrace/common/funcs/tst.cleanpath.d ]
Files left in work directory after failure: check.yRFnvD, tmp.aqs1o8zp, tmp.gL6Bm0MG
t_dtrace_contrib:tst_cleanpath_d  ->  broken: Test case body timed out

If we execute tst.cleanpath.d directly:

lwhsu@FreeBSD-12-t:/usr/tests/cddl/usr.sbin/dtrace/common/funcs > sudo dtrace -C -s tst.cleanpath.d
dtrace: buffer size lowered to 2m
dtrace: 1 dynamic variable drop
(hangs)

Sorry for being picky, but could you paste the output of this test without the change?

There is nothing out stdout, the error messages from kyua are as following:

Thanks. This is a bit surprising. How many CPUs does the system have?

Thanks. This is a bit surprising. How many CPUs does the system have?

Two: https://github.com/freebsd/freebsd-ci/blob/master/jobs/FreeBSD-head-amd64-dtrace_test/build.sh#L25

And I am thinking changing to 1 to make more room for other jobs in the future.

This revision is now accepted and ready to land.Jul 25 2017, 10:25 AM
This revision was automatically updated to reflect the committed changes.