Differential D10430

Frames that are not considered for LRO should not be counted in LRO stats.
ClosedPublic
Actions

Authored by np on Apr 19 2017, 11:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 14, 1:23 PM

	Unknown Object (File)
	Sat, Sep 12, 8:17 PM

	Unknown Object (File)
	Fri, Sep 11, 12:29 AM

	Unknown Object (File)
	Sun, Sep 6, 4:13 PM

	Unknown Object (File)
	Sun, Sep 6, 11:53 AM

	Unknown Object (File)
	Sat, Sep 5, 6:15 AM

	Unknown Object (File)
	Fri, Sep 4, 12:06 PM

	Unknown Object (File)
	Fri, Sep 4, 4:23 AM

Subscribers

Details

Reviewers

gnn
• hselasky
gallatin

Group Reviewers

network
transport

Commits

rS317389: Frames that are not considered for LRO should not be counted in LRO statistics.

Summary

The code will currently count any (even non-TCP) frame as queued/flushed
in the LRO stats if IFCAP_LRO is disabled or csum_flags is 0. It would
have been cleaner for tcp_lro_queue_mbuf to be able to return
TCP_LRO_CANNOT and let the caller figure out what to do. But I don't
want to touch the KPI and all the drivers so the proposed change fixes
the stats only.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

np created this revision.Apr 19 2017, 11:28 PM

Herald added a reviewer: transport. · View Herald TranscriptApr 19 2017, 11:28 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B8799: Diff 27561.Apr 20 2017, 12:14 AM

gnn accepted this revision.Apr 22 2017, 4:30 PM

This revision is now accepted and ready to land.Apr 22 2017, 4:30 PM

Might want to ask @gallatin for a review aswell.

gallatin accepted this revision.Apr 24 2017, 10:22 PM

Closed by commit rS317389: Frames that are not considered for LRO should not be counted in LRO statistics. (authored by np). · Explain WhyApr 24 2017, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

2 lines

Diff 27701

head/sys/netinet/tcp_lro.c

Loading...