Page MenuHomeFreeBSD

Frames that are not considered for LRO should not be counted in LRO stats.
ClosedPublic

Authored by np on Apr 19 2017, 11:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 8, 2:34 PM
Unknown Object (File)
Wed, Nov 5, 11:25 PM
Unknown Object (File)
Sun, Nov 2, 11:19 AM
Unknown Object (File)
Sun, Nov 2, 11:19 AM
Unknown Object (File)
Sun, Nov 2, 11:19 AM
Unknown Object (File)
Sun, Nov 2, 7:03 AM
Unknown Object (File)
Fri, Oct 31, 7:42 PM
Unknown Object (File)
Fri, Oct 31, 5:50 PM

Details

Summary

The code will currently count any (even non-TCP) frame as queued/flushed
in the LRO stats if IFCAP_LRO is disabled or csum_flags is 0. It would
have been cleaner for tcp_lro_queue_mbuf to be able to return
TCP_LRO_CANNOT and let the caller figure out what to do. But I don't
want to touch the KPI and all the drivers so the proposed change fixes
the stats only.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable