Fixup compilation and enable dtrace support for mips64
ClosedPublic

Authored by lidl on Mon, Sep 4, 10:41 PM.

Details

Summary

As it stands right now, one cannot compile the dtrace
modules for mips64. With this patch, the modules
compile, and can be loaded into the kernel via
kldload (or just by running 'dtrace -l').

While the dtrace functionality does not currently work,
this is a useful stepping stone to further explore getting
it to work.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lidl created this revision.Mon, Sep 4, 10:41 PM
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptMon, Sep 4, 10:41 PM
Herald added a subscriber: imp. · View Herald Transcript
emaste added inline comments.Mon, Sep 4, 10:45 PM
sys/modules/dtrace/dtraceall/dtraceall.c
73 ↗(On Diff #32650)

Does __mips64__ actually get defined? AFAIK __mips__ is on both 32- and 64-bit so it wouldn't make a difference.

lidl added inline comments.Mon, Sep 4, 10:50 PM
sys/modules/dtrace/dtraceall/dtraceall.c
73 ↗(On Diff #32650)

Heh. You are correct, gcc (4.2.1, the in-tree one) only defines
mips64 not mips64__.

I will remove the mips64 code.

lidl updated this revision to Diff 32653.Mon, Sep 4, 10:56 PM

Address emaste's comment about mips64

lidl marked 2 inline comments as done.Mon, Sep 4, 10:56 PM
markj accepted this revision.Tue, Sep 5, 1:39 AM
gnn accepted this revision.Wed, Sep 6, 12:17 AM

LGTM

This revision is now accepted and ready to land.Wed, Sep 6, 12:17 AM
This revision was automatically updated to reflect the committed changes.