Page MenuHomeFreeBSD
Differential D12227

Fixup compilation and enable dtrace support for mips64
ClosedPublic
Actions

Authored by • lidl on Sep 4 2017, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 12:53 AM
Unknown Object (File)
Feb 22 2024, 1:51 PM
Unknown Object (File)
Feb 22 2024, 5:19 AM
Unknown Object (File)
Feb 9 2024, 11:08 AM
Unknown Object (File)
Dec 20 2023, 3:09 AM
Unknown Object (File)
Dec 16 2023, 4:56 AM
Unknown Object (File)
Oct 28 2023, 6:34 PM
Unknown Object (File)
Oct 4 2023, 5:02 PM
View All 28 Files
Subscribers
imp
DTrace

Details

Reviewers
emaste
gnn
sbruno
jhibbits
markj
Commits
rS323206: Enable dtrace support for mips64 and the ERL kernel config
Summary

As it stands right now, one cannot compile the dtrace
modules for mips64. With this patch, the modules
compile, and can be loaded into the kernel via
kldload (or just by running 'dtrace -l').

While the dtrace functionality does not currently work,
this is a useful stepping stone to further explore getting
it to work.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• lidl created this revision.Sep 4 2017, 10:41 PM
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptSep 4 2017, 10:41 PM
Herald added a subscriber: imp. · View Herald Transcript
emaste added inline comments.Sep 4 2017, 10:45 PM
sys/modules/dtrace/dtraceall/dtraceall.c
73 ↗(On Diff #32650)

Does __mips64__ actually get defined? AFAIK __mips__ is on both 32- and 64-bit so it wouldn't make a difference.

• lidl added inline comments.Sep 4 2017, 10:50 PM
sys/modules/dtrace/dtraceall/dtraceall.c
73 ↗(On Diff #32650)

Heh. You are correct, gcc (4.2.1, the in-tree one) only defines
mips64 not mips64__.

I will remove the mips64 code.

• lidl updated this revision to Diff 32653.Sep 4 2017, 10:56 PM

Address emaste's comment about mips64

• lidl marked 2 inline comments as done.Sep 4 2017, 10:56 PM
markj accepted this revision.Sep 5 2017, 1:39 AM
gnn accepted this revision.Sep 6 2017, 12:17 AM

LGTM

This revision is now accepted and ready to land.Sep 6 2017, 12:17 AM
Closed by commit rS323206: Enable dtrace support for mips64 and the ERL kernel config (authored by • lidl). · Explain WhySep 6 2017, 3:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
dev/
dtrace/
mips/
2 lines
2 lines
fbt/
mips/
1 line
mips/
conf/
9 lines
modules/
dtrace/
5 lines
dtraceall/
2 lines
3 lines

Diff 32701

View Options

head/sys/cddl/dev/dtrace/mips/dtrace_asm.S

Loading...
View Options

head/sys/cddl/dev/dtrace/mips/dtrace_subr.c

Loading...
View Options

head/sys/cddl/dev/fbt/mips/fbt_isa.c

Loading...
View Options

head/sys/mips/conf/ERL

Loading...
View Options

head/sys/modules/dtrace/Makefile

Loading...
View Options

head/sys/modules/dtrace/dtraceall/Makefile

Loading...
View Options

head/sys/modules/dtrace/dtraceall/dtraceall.c

Loading...