Page MenuHomeFreeBSD

DTtrace test suite driver: execute the verifying script generated by test case
ClosedPublic

Authored by lwhsu on Jul 24 2017, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:51 AM
Unknown Object (File)
Sat, Mar 23, 5:51 AM
Unknown Object (File)
Sat, Mar 23, 5:51 AM
Unknown Object (File)
Sat, Mar 23, 5:51 AM
Unknown Object (File)
Sat, Mar 23, 5:33 AM
Unknown Object (File)
Dec 20 2023, 7:42 AM
Unknown Object (File)
Sep 17 2023, 7:14 AM
Unknown Object (File)
Sep 17 2023, 7:14 AM
Subscribers

Details

Summary

The test case common.funcs.t_dtrace_contrib.tst_basename_d generates a verifying
script which needs to be run to complete the test.

While here, add missing shebang.

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace && kyua test

This depends on D11707 which fixes common.funcs.t_dtrace_contrib.tst_basename_d

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cddl/usr.sbin/dtrace/tests/tools/dtest.sh
90 ↗(On Diff #31136)

I don't see why we're suppressing stderr here. Don't we want to see it? I would instead write:

head -n 1 $STDOUT | grep -q -E <regexp>

cddl/usr.sbin/dtrace/tests/tools/dtest.sh
90 ↗(On Diff #31136)

I originally though it suppress the case that STDOUT does not exist, but now I think it's also fine to yell when that does happen. The 2nd suppressing is similar.

lwhsu edited edge metadata.
  • Remove unnecessary stderr suppressing
  • Use -q to suppress grep(1) output
This revision is now accepted and ready to land.Jul 25 2017, 10:24 AM
This revision was automatically updated to reflect the committed changes.