Fix DTrace test case: common.misc.t_dtrace_contrib.tst_macroglob_ksh
ClosedPublic

Authored by lwhsu on Jul 24 2017, 12:40 PM.

Details

Summary

This case does glob on syscalls, and fails on FreeBSD because of syscall set differs than Solaris.

Modify glob patterns and expected output to match FreeBSD's implementation.

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace/common/misc && kyua debug t_dtrace_contrib:tst_macroglob_ksh

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lwhsu created this revision.Jul 24 2017, 12:40 PM
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJul 24 2017, 12:40 PM
Herald added a subscriber: imp. · View Herald Transcript
lwhsu edited the summary of this revision. (Show Details)Jul 24 2017, 12:41 PM
lwhsu edited the summary of this revision. (Show Details)
markj added inline comments.Jul 24 2017, 6:59 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh
34 ↗(On Diff #31127)

I find it a bit easier to read if the pipe comes before the newline, as you did in the final dtrace invocation.

markj accepted this revision.Jul 24 2017, 6:59 PM
lwhsu marked an inline comment as done.Jul 24 2017, 10:21 PM
lwhsu added inline comments.
cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh
34 ↗(On Diff #31127)

right, I reformatted them but missed this one.

ngie accepted this revision.Jul 24 2017, 10:24 PM
markj accepted this revision.Jul 24 2017, 10:25 PM
gnn accepted this revision.Jul 25 2017, 10:24 AM
This revision is now accepted and ready to land.Jul 25 2017, 10:24 AM
This revision was automatically updated to reflect the committed changes.