Page MenuHomeFreeBSD

Fix test timeout: common.speculation.t_dtrace_contrib.tst_NoSpecBuffer_d
ClosedPublic

Authored by lwhsu on Jul 20 2017, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 12:17 AM
Unknown Object (File)
Mar 23 2024, 5:46 AM
Unknown Object (File)
Mar 23 2024, 5:46 AM
Unknown Object (File)
Mar 23 2024, 5:46 AM
Unknown Object (File)
Mar 23 2024, 5:46 AM
Unknown Object (File)
Mar 23 2024, 5:46 AM
Unknown Object (File)
Mar 23 2024, 5:46 AM
Unknown Object (File)
Mar 23 2024, 5:33 AM
Subscribers

Details

Summary

This test timeout on a quiet system because there is nobody triggers
syscall::open:entry and syscall::: probe while test execution.

Add a simple script to generate some noise, it sleeps for 1 second at begining
because current dtest script doesn't support execute a program after invoking
dtrace script.

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace/common/speculation && kyua debug t_dtrace_contrib:tst_NoSpecBuffer_d

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Why is a binary file being checked in?

In D11671#241800, @ngie wrote:

Why is a binary file being checked in?

That's not a binary file, it's a script which needs to be run while test running, like other .exe files in test suite. arc(1) treats it as binary...

svn ps svn:mime-type text/plain tst.NoSpecBuffer.exe

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
27 ↗(On Diff #31016)

This is susceptible to the same race I mentioned in the other review. IMO it is better to just loop forever and let the test harness kill the .exe process once the test has passed.

lwhsu edited edge metadata.

Add a sleep(1) to avoid CPU busy loop.

This revision is now accepted and ready to land.Jul 25 2017, 10:25 AM
This revision was automatically updated to reflect the committed changes.