Is this still a valid review? I recall something related was committed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 27 2019
Apr 24 2019
Apr 19 2019
Apr 18 2019
Apr 17 2019
Apr 13 2019
Apr 10 2019
I still hope to hear from the DTrace experts, but I like this very much. Thanks!
Apr 8 2019
Very cool (but I am biased since I suggested the fusefs-dtrace changes as a starting point)!
Apr 5 2019
Mar 1 2019
In D19325#415619, @mckusick wrote:I recently added the new error EINTEGRITY which is intended for use when a cylinder group or other filesystem structure has an integrity error.
Feb 27 2019
Upon further thought: the situation is very different for ext2fs than to a filesystem in which the all the system depends as in UFS.
In D19327#414960, @fsu wrote:In D19327#413791, @pfg wrote:Note why we specifically set ip->i_flags = 0 since r294652:
The ip->i_flags will be zero in all cases inside this function because we does not read new inode from disk at all for now and inode is allocated thru malloc with M_ZERO flag.
OK, you are rught, we were not allocating (with M_ZERO) this before.
Hi Kirk;
We have this as a panic in UFS, as well.
We should probably keep this panic for consistency with UFS, which also panics on this case.
Feb 25 2019
Note why we specifically set ip->i_flags = 0 since r294652:
Feb 24 2019
Feb 22 2019
LGTM.
FWIW, the GPLv3 version does an ugly calloc() dance with pointers which looks a lot more confusing.
I am unsure if it is a style rule but we generally place such pragmas before and after all declarations so that they don't get in the way of easier reading.
Feb 20 2019
Feb 19 2019
In D13706#411805, @rgrimes wrote:pfg I think you miss understood, and upon looking I was not clear, it is not you that I am unhappy with about "playing with copyrights and licenses", it is NetBSD and possibly Charles Hannum who as Robert points out modified a license without ALL authors approval. I would be very upset if someone disturbed my disclaimer in this manner.
In D13706#411735, @rgrimes wrote:Upon closer examination of this there are some issues, it alters a license post fact of copyrights asserted by some, and changes the clause in the license from Author to NetBSD, which effects the since of the copyright. I really wish the playing with Copyrights and Licenses would stop, this is a good example, of a well meant change, causing an ugly problem. For examle, the disclaimer is now in the name NetBSD, so what happened to the disclaim asserted by nCircle Network, and Robert Watson?
(trasz is the expert here)
Feb 15 2019
If it's not needed then just lets not spend time on it.
Note that I have no idea of MIPS asm, just noticed the commit on OpenBSD MIPS64 .. feel free to commit if it works for you.
Feb 12 2019
Unsign uh_hashmask
(Don't expect any failure but will test anyways)
Feb 11 2019
In D19148#409628, @mav wrote:In D19148#409623, @pfg wrote:I thought of that but I saw a -1 when calculating it:
hash->uh_hashmask = hash->uh_hashsize - 1;.A hashsize of zero makes little sense but it is still a valid value (?).
hashsize of zero makes no sense to me. I haven't checked how exactly it is initialized and whether it is used for some implementation reasons, but smallest possible size of hash is 1 with mask of 0. For size of 0 there is just no meaningful mask. Plus few places where uh_hashmask is used, do not care whether it is negative or overflown unsigned.
Missing hval unsigning (pointed out by mav).
In D19148#409622, @mav wrote:Generally I agree with it. I spotted it too when worked on my change. It just needs 8 times more RAM then what we have now to overflow, so I preferred my patch to be minimal. Just going that way, why not make uh_hashmask also unsigned?
Feb 10 2019
Jan 28 2019
Jan 25 2019
Jan 21 2019
Jan 14 2019
Jan 11 2019
FWIW, this is currently my favorite IDE on FreeBSD: netbeans has problems refreshing.
VSCode is not yet ported :(.
Jan 10 2019
Jan 7 2019
Jan 1 2019
FWIW, I have a patch from the late ache@ to finish the removal of __collate_range_cmp() started in r302512.
It is practically impossible to remove a symbol as that would in theory break the ABI, so I understand we may be wary of adding new ones.
Dec 31 2018
Dec 30 2018
Dec 27 2018
Fix issues pointed out by mat@
- Update to 2018.3.2
- Move to devel as we don't really depend on the intellij infrastructure.
- Use native file watching support as in the latest intellij port.
Dec 23 2018
Commtted as r342379
Thanks for the suggestions.
Keep the documentation consitent in the headers and manpage as well.
(Yes, I still have to update the manpage date before committing).
Dec 21 2018
Dec 19 2018
For the record: while it is good practice to request reviews before committing, IMHO they dont make much sense, and are not required at all, for reverts. After all they stand for things all the initial reviewers missed in the first place ;).
Dec 16 2018
In D18579#396127, @cy wrote:I haven't figured out how to diff deleted files in git yet. I'll upload it soon.
If people decide not to make a decision now this revision can be abandoned and I can save it for later. git stash is my friend.
In D18579#396118, @rgrimes wrote:Age should not be a criteria for removal. BSD is old, very old, shall we remove it simply cause it is old? IMHO you all are getting way ahead of the process, having reviews to remove code before the cost/benefit and open discussions happens is backwards.
Dec 12 2018
Dec 8 2018
Use WRKSRC instead of WRKDIST.
Still passes portlint and check-plist
Dec 7 2018
Dec 6 2018
Really add the symlink
In D18445#392821, @rpokala wrote:Please create links for ext3fs.5 and ext4fs.5; in share/man/man5/Makefile, add these to the list:
MLINKS+= ext2fs.5 ext3fs.5 MLINKS+= ext2fs.5 ext4fs.5
I agree the ext4fs link is useful. the ext3fs is probably not
Add a soflink for ext4fs. I am not currently adding a link to ext3 since
linux doesn't seem to carry it anymore and we don't support the main
feature it brought: journalling.
Dec 4 2018
Nov 23 2018
Nice!
Looks good to me, but it would be nice to have input from kevans as well.
Aha .. so nice to find a bug , thanks !
Nov 22 2018
I am not an expert on the area but I see where the comment comes from: