Page MenuHomeFreeBSD
Differential D19240

Remove redundant code in acl_strip
ClosedPublic
Actions

Authored by sef on Feb 18 2019, 11:23 PM.
Tags
None
Referenced Files
F176524356: D19240.id54053.diff
Mon, Oct 19, 1:22 PM
Unknown Object (File)
Fri, Oct 16, 2:06 PM
Unknown Object (File)
Fri, Oct 16, 6:20 AM
Unknown Object (File)
Wed, Oct 14, 4:19 PM
Unknown Object (File)
Sat, Oct 10, 1:39 PM
Unknown Object (File)
Sat, Oct 10, 1:26 PM
Unknown Object (File)
Sat, Oct 10, 1:26 PM
Unknown Object (File)
Sat, Oct 10, 1:25 PM
View All Files
Subscribers
imp

Details

Reviewers
trasz
pfg
Commits
rS344294: Remove some redundant code in _posix1e_acl_strip_np
Summary

This was an old change I'd sent in a few years ago. I discovered it by looking at the code, while I was writing some ACL-manipulation code and was looking at the internals: acl_copy_entry() already sets the tag type, permset, and brand.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sef created this revision.Feb 18 2019, 11:23 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 18 2019, 11:23 PM
trasz accepted this revision.Feb 19 2019, 1:01 PM
This revision is now accepted and ready to land.Feb 19 2019, 1:01 PM
pfg accepted this revision.Feb 19 2019, 3:34 PM

(trasz is the expert here)

Closed by commit rS344294: Remove some redundant code in _posix1e_acl_strip_np (authored by sef). · Explain WhyFeb 19 2019, 7:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
posix1e/
9 lines

Diff 54078

View Options

head/lib/libc/posix1e/acl_strip.c

Loading...