Differential D19240

Remove redundant code in acl_strip
ClosedPublic
Actions

Authored by sef on Feb 18 2019, 11:23 PM.

Tags

None

Referenced Files

	F154218199: D19240.id54078.diff
	Mon, Apr 27, 5:06 AM

	Unknown Object (File)
	Wed, Apr 22, 5:40 AM

	Unknown Object (File)
	Wed, Apr 22, 2:28 AM

	Unknown Object (File)
	Tue, Apr 21, 11:35 AM

	Unknown Object (File)
	Tue, Apr 21, 10:41 AM

	Unknown Object (File)
	Mon, Apr 20, 10:44 PM

	Unknown Object (File)
	Sat, Apr 18, 10:15 PM

	Unknown Object (File)
	Tue, Apr 7, 8:20 PM

View All Files

Subscribers

imp

Details

Reviewers

trasz
pfg

Commits

rS344294: Remove some redundant code in _posix1e_acl_strip_np

Summary

This was an old change I'd sent in a few years ago. I discovered it by looking at the code, while I was writing some ACL-manipulation code and was looking at the internals: acl_copy_entry() already sets the tag type, permset, and brand.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sef created this revision.Feb 18 2019, 11:23 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 18 2019, 11:23 PM

trasz accepted this revision.Feb 19 2019, 1:01 PM

This revision is now accepted and ready to land.Feb 19 2019, 1:01 PM

(trasz is the expert here)

Closed by commit rS344294: Remove some redundant code in _posix1e_acl_strip_np (authored by sef). · Explain WhyFeb 19 2019, 7:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

posix1e/

acl_strip.c

9 lines

Diff 54078

View Options

head/lib/libc/posix1e/acl_strip.c

Remove redundant code in acl_stripClosedPublicActions