Page MenuHomeFreeBSD
Differential D19322

Make superblock reading logic more strict.
ClosedPublic
Actions

Authored by fsu on Feb 24 2019, 1:13 PM.
Tags
None
Referenced Files
F147312876: D19322.id54668.diff
Mon, Mar 9, 9:27 PM
F147304227: D19322.id54285.diff
Mon, Mar 9, 7:52 PM
Unknown Object (File)
Sat, Mar 7, 8:52 AM
Unknown Object (File)
Jan 26 2026, 12:05 AM
Unknown Object (File)
Jan 9 2026, 5:28 PM
Unknown Object (File)
Dec 12 2025, 8:32 PM
Unknown Object (File)
Nov 28 2025, 6:17 AM
Unknown Object (File)
Nov 26 2025, 9:04 AM
View All Files
Subscribers
imp

Details

Reviewers
pfg
Commits
rS345265: MFC r344751:
rS344751: Make superblock reading logic more strict.
Summary

Now the comput_sb_data() function checks on-disk superblock data fields more carefully. Also, the cylinder group validation function is added.
It should decrease ability to mount filesystems with corrupted superblock data.

Test Plan

Typical fsx/fstorture tests to avoid regression.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fsu created this revision.Feb 24 2019, 1:13 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 24 2019, 1:13 PM
pfg accepted this revision.Feb 27 2019, 2:43 PM
pfg added inline comments.
sys/fs/ext2fs/ext2fs.h
398 ↗(On Diff #54285)

Use a TAB after the

#define
This revision is now accepted and ready to land.Feb 27 2019, 2:43 PM
Closed by commit rS344751: Make superblock reading logic more strict. (authored by fsu). · Explain WhyMar 4 2019, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
ext2fs/
10 lines
3 lines
266 lines
5 lines

Diff 54668

View Options

head/sys/fs/ext2fs/ext2_alloc.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_extern.h

Loading...
View Options

head/sys/fs/ext2fs/ext2_vfsops.c

Loading...
View Options

head/sys/fs/ext2fs/ext2fs.h

Loading...