Page MenuHomeFreeBSD

Make superblock reading logic more strict.
ClosedPublic

Authored by fsu on Feb 24 2019, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 6:15 PM
Unknown Object (File)
Mon, Oct 20, 6:15 PM
Unknown Object (File)
Mon, Oct 20, 6:15 PM
Unknown Object (File)
Mon, Oct 20, 5:01 AM
Unknown Object (File)
Thu, Oct 9, 10:28 PM
Unknown Object (File)
Fri, Oct 3, 12:00 AM
Unknown Object (File)
Tue, Sep 30, 8:00 AM
Unknown Object (File)
Sun, Sep 28, 9:58 AM
Subscribers

Details

Summary

Now the comput_sb_data() function checks on-disk superblock data fields more carefully. Also, the cylinder group validation function is added.
It should decrease ability to mount filesystems with corrupted superblock data.

Test Plan

Typical fsx/fstorture tests to avoid regression.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pfg added inline comments.
sys/fs/ext2fs/ext2fs.h
398 ↗(On Diff #54285)

Use a TAB after the

#define
This revision is now accepted and ready to land.Feb 27 2019, 2:43 PM
This revision was automatically updated to reflect the committed changes.