Page MenuHomeFreeBSD
Differential D10009

Fix a memory leak in bhyve
AbandonedPublic
Actions

Authored by markj on Mar 14 2017, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:00 PM
Unknown Object (File)
Mon, Nov 18, 8:30 AM
Unknown Object (File)
Sun, Nov 10, 8:52 PM
Unknown Object (File)
Sat, Nov 9, 9:59 PM
Unknown Object (File)
Sat, Nov 9, 11:21 AM
Unknown Object (File)
Sat, Nov 9, 8:32 AM
Unknown Object (File)
Tue, Oct 29, 2:35 PM
Unknown Object (File)
Tue, Oct 29, 9:28 AM
View All 43 Files
Subscribers
bcran
imp
markj
rgrimes

Details

Reviewers
neel
trix_juniper.net
rgrimes
Group Reviewers
bhyve
Commits
rS334016: We must free the variable str.
Summary

pci_emul.c pci_parse_slot
It is alway appropiate to free 'str' so remove the if-check.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trix_juniper.net created this revision.Mar 14 2017, 9:43 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 14 2017, 9:43 PM
pfg added a reviewer: grehan.Mar 15 2017, 12:45 AM
pfg edited edge metadata.

The change looks good to me but it isn't my area. Add Peter.

grehan accepted this revision.Mar 15 2017, 1:18 AM
This revision is now accepted and ready to land.Mar 15 2017, 1:18 AM
Closed by commit rS334016: We must free the variable str. (authored by araujo). · Explain WhyMay 22 2018, 4:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: rgrimes. · View Herald TranscriptMay 22 2018, 4:08 AM
araujo reopened this revision.May 22 2018, 6:05 AM
araujo added a subscriber: araujo.

It breaks pci_emul in other places, needs further investigation.
I'm taking it.

rgrimes edited reviewers, added: bhyve; removed: grehan.Feb 20 2019, 5:57 PM
araujo removed a subscriber: araujo.Feb 22 2019, 1:19 AM
pfg resigned from this revision.Apr 27 2019, 2:30 PM
pfg removed a reviewer: pfg.
Herald added a subscriber: bcran. · View Herald TranscriptApr 27 2019, 2:30 PM
markj added a subscriber: markj.May 24 2019, 3:04 PM

It looks like the original code was correct. Is there any reason to keep this review open?

rgrimes resigned from this revision.May 24 2019, 3:23 PM
Herald added a subscriber: rgrimes. · View Herald TranscriptMay 24 2019, 3:23 PM
rgrimes added a comment.May 24 2019, 3:23 PM

Concur, but not sure how to force it closed.

markj commandeered this revision.May 24 2019, 3:24 PM
markj abandoned this revision.
markj added a reviewer: trix_juniper.net.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
3 lines

Diff 42830

View Options

head/usr.sbin/bhyve/pci_emul.c

Loading...