[NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE

[pfg]

Summary

PhpStorm is a high quaity IDE based for PHP and related frameworks.
New port based on intellij-rubymine plus cleanups to remove the linux
openjdk.
PR: 233842

Test Plan

Known to pass portlint and check-plist.

[mat]

java/jetbrains-phpstorm/Makefile

33–34 ↗

(On Diff #51733)

Any reason you are creating a new variable instead of using WRKSRC everywhere?

[pfg]

Use WRKSRC instead of WRKDIST.
Still passes portlint and check-plist

java/jetbrains-phpstorm/Makefile

33–34 ↗

(On Diff #51733)

WRKDIST came from the original intellij-Rubymine port on which this was based. I later noted the port wanted WRKSRC and added it. I will try defining only WRKSRC.

[pfg]

• Update to 2018.3.2
• Move to devel as we don't really depend on the intellij infrastructure.
• Use native file watching support as in the latest intellij port.

[mat]

devel/jetbrains-phpstorm/Makefile

34–36 ↗

(On Diff #52342)

Why +=?

37 ↗

(On Diff #52342)

Add blank line before target.

[pfg]

devel/jetbrains-phpstorm/Makefile

34–36 ↗

(On Diff #52342)

Hmm .. those lines come from the original intellij port, I'll have to look at what can be removed.. thanks!

[pfg]

Fix issues pointed out by mat@

[pfg]

ping?

FWIW, this is currently my favorite IDE on FreeBSD: netbeans has problems refreshing.
VSCode is not yet ported :(.

[tobik]

In D18477#401611, @pfg wrote:

ping?

FWIW, this is currently my favorite IDE on FreeBSD: netbeans has problems refreshing.
VSCode is not yet ported :(.

If it builds and runs then go for it.

Approved by:	ports (tobik)