Page MenuHomeFreeBSD

Replace two-operand instruction aliases that clang does not understand with the three-operand instructions.
AbandonedPublic

Authored by pfg on Feb 15 2019, 4:13 AM.

Details

Reviewers
jhb
Summary

No binary change with gas.
Obtained from: OpenBSD (CVS Rev. 1.9)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22515
Build 21662: arc lint + arc unit

Event Timeline

pfg created this revision.Feb 15 2019, 4:13 AM
pfg added a comment.Feb 15 2019, 4:18 AM

Note that I have no idea of MIPS asm, just noticed the commit on OpenBSD MIPS64 .. feel free to commit if it works for you.

jhb added a comment.Feb 15 2019, 6:13 PM

I haven't needed this when building mips64 on clang 6. clang 7 can't build mips due to a different regression (but not in this file).

imp added a comment.Feb 15 2019, 7:04 PM
In D19203#410890, @jhb wrote:

I haven't needed this when building mips64 on clang 6. clang 7 can't build mips due to a different regression (but not in this file).

IIRC, OpenBSD needed this only for older versions of clang that didn't really support mips assembler completely (can't recall if those were the in-tree ones, or the snapshots by the folks doing the mips port). I helped Ed with a number of these a while ago. My sense is that we shouldn't do this unless we have a demonstrated need. Though, having said that, this change doesn't hurt anything.

pfg abandoned this revision.Feb 15 2019, 8:41 PM

If it's not needed then just lets not spend time on it.