Page MenuHomeFreeBSD

Remove amd(8) from base
AbandonedPublic

Authored by cy on Dec 16 2018, 5:43 PM.

Details

Summary

Remove the redundant amd(8) in base. It's old and we already have am-utils in ports.

I used git diff -U99999 which doesn't list the deleted files.

Test Plan

Currently being tested on universe13b.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Age should not be a criteria for removal. BSD is old, very old, shall we remove it simply cause it is old? IMHO you all are getting way ahead of the process, having reviews to remove code before the cost/benefit and open discussions happens is backwards.

Furthermore a review to remove a feature that does not first have a review to add deprecation notices is again, out of order.

And finally a diff that does not actually show the deleted files is, well, rather hard to review.

Age should not be a criteria for removal. BSD is old, very old, shall we remove it simply cause it is old? IMHO you all are getting way ahead of the process, having reviews to remove code before the cost/benefit and open discussions happens is backwards.

I requested the removal since we already have autofs(5) for several years. It was discussed but left pending a while ago. FWIW, DragonFlyBSD did the same about 2 years ago.

Furthermore a review to remove a feature that does not first have a review to add deprecation notices is again, out of order.

And finally a diff that does not actually show the deleted files is, well, rather hard to review.

I agree on those: It seems like we are missing a "svn rm" from the diff.

I haven't figured out how to diff deleted files in git yet. I'll upload it soon.

If people decide not to make a decision now this revision can be abandoned and I can save it for later. git stash is my friend.

This contains all the delete as svn would.

In D18579#396127, @cy wrote:

I haven't figured out how to diff deleted files in git yet. I'll upload it soon.

If people decide not to make a decision now this revision can be abandoned and I can save it for later. git stash is my friend.

I think you can work on the deprecation notice (manpages .. what else?)) right away .... that would act as a "heads up" for anyone that might object.

git stash push -m amd-deletion

I will add deprecation notices for deletion on March 31, 2019.

tinderbox rc=0. Ready to commit when the decision is made.