Thank you.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 27 2020
Jul 26 2020
Jul 14 2020
Jul 13 2020
In D25640#567601, @pfg wrote:LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.
In D25398#560911, @pstef wrote:It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.
remove debugging cruft
Jul 11 2020
Jun 23 2020
Jun 22 2020
Jun 21 2020
Jun 18 2020
I think this looks good.
Jun 15 2020
Jun 13 2020
Jun 11 2020
Jun 9 2020
In D22160#555029, @phil wrote:The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?
Thanks,
Phil
Jun 8 2020
In D22160#555029, @phil wrote:The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?
Thanks,
Phil
Jun 7 2020
In D25165#554658, @trasz wrote:And yeah, I think it’s a good idea to fix all of them. Still, this is fine too.
Jun 6 2020
In D25166#554560, @bjk wrote:I expect I should be the one committing this?
But I will hold off for a bit in case someone wants to respond to the 'kldstat' remark.
Actually, there are more timeout(9) references, wonder if it would make sense to gather all of those in one review?
Jun 5 2020
Jun 4 2020
May 27 2020
In D25013#550908, @phil wrote:Just knowing that the "--libxo" was used is not sufficient, since there are options that should not affect output (e.g. color, no-humanize, warn).
Can you describe more exactly when you want to avoid truncation? I'm guessing you want this for the "encoding" output styles (XML, JSON) and not text, but do you want to truncate HTML output?
Maybe the test you are needing is just "if (xo_get_style(NULL) == XO_STYLE_TEXT)"?
Thanks,
Phil
May 26 2020
May 19 2020
In D24919#548530, @yuripv wrote:In D24919#548529, @bapt wrote:Have you contacted the upstream? https://github.com/lichray/nvi2
Will do, forgot about it! Thanks.
In D24919#548529, @bapt wrote:Have you contacted the upstream? https://github.com/lichray/nvi2
May 16 2020
Feb 21 2020
Correct sysctl description.
Feb 17 2020
Jan 21 2020
Jan 9 2020
In D23109#506462, @yuripv wrote:I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:
if (table->__collate_load_error == 0 && table->header != NULL && strcmp(table->header.locale, encoding) == 0) return (_LDP_LOADED);Not completely sure about the table->header check here as we already checked that the table was loaded, but it's just an idea.
(P.S. I think encoding is really a wrong argument name here, as it's full locale name.)
I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:
Oct 28 2019
Oct 26 2019
Oct 19 2019
Oct 18 2019
Oct 10 2019
Oct 8 2019
Sep 30 2019
Sep 25 2019
Sep 24 2019
Warner, does this make sense to you/won't interfere with other changes you might be working on?
Sep 22 2019
Sep 19 2019
actually split the synopsis into separate options that can't be used together
As noted by @imp, there are better ways to do this.
Sep 16 2019
Sep 11 2019
Correct the .Fo field (remove *). Ingo did agree that .Fo (f) shouldn't trigger the warning and it will be supressed in the future. For the moment, we'll just have a non-fatal warning.
Sep 10 2019
- use sbuf functions
- also handle am_pm
- mark all keywords not specified by POSIX (e.g. abmon_1 through abmon_12, am_str, pm_str, ...) as local additions as other systems (at least Linux and Solaris) do not handle them
- add tests
Sep 9 2019
In D21569#469935, @0mp wrote:Seems fine to me.
Sep 3 2019
Sep 2 2019
Aug 30 2019
Aug 29 2019
@ian I'm not sure if I should put you in 'submitted by' or 'reviewed by' line, you did both :)