As reported in PR237752, our locale utility doesn't handle the day, abday, mon, abmon keywords, and that seems to violate POSIX.
Also handle am_pm, which is missing as well.
Details
Details
- Reviewers
bapt - Commits
- rS352138: locale: handle day, abday, mon, abmon, am_pm keywords
Simply running locale -k, locale -k day abday mon abmon for the moment. If this implementation looks sane enough, I'll add the test cases for locale(1).
$ LC_ALL=en_US.UTF-8 locale -k day abday mon abmon day="Sunday";"Monday";"Tuesday";"Wednesday";"Thursday";"Friday";"Saturday" abday="Sun";"Mon";"Tue";"Wed";"Thu";"Fri";"Sat" mon="January";"February";"March";"April";"May";"June";"July";"August";"September";"October";"November";"December" abmon="Jan";"Feb";"Mar";"Apr";"May";"Jun";"Jul";"Aug";"Sep";"Oct";"Nov";"Dec" $ LC_ALL=ru_RU.UTF-8 locale -k day abday mon abmon day="воскресенье";"понедельник";"вторник";"среда";"четверг";"пятница";"суббота" abday="вс";"пн";"вт";"ср";"чт";"пт";"сб" mon="января";"февраля";"марта";"апреля";"мая";"июня";"июля";"августа";"сентября";"октября";"ноября";"декабря" abmon="янв.";"февр.";"марта";"апр.";"мая";"июня";"июля";"авг.";"сент.";"окт.";"нояб.";"дек."
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This looks sane to me!
| usr.bin/locale/locale.c | ||
|---|---|---|
| 803 ↗ | (On Diff #61552) | that if is useless, free deals properly with NULL |
| usr.bin/locale/locale.c | ||
|---|---|---|
| 803 ↗ | (On Diff #61552) | Yes, but I'm NOT checking kwval for NULL, rather if we did allocate the memory for kwval -- otherwise we'll try to free something we didn't allocate. |
Comment Actions
- use sbuf functions
- also handle am_pm
- mark all keywords not specified by POSIX (e.g. abmon_1 through abmon_12, am_str, pm_str, ...) as local additions as other systems (at least Linux and Solaris) do not handle them
- add tests