Page MenuHomeFreeBSD

taskqueue(9): reference callout(9) instead of timeout(9)
ClosedPublic

Authored by yuripv on Jun 6 2020, 10:40 AM.

Details

Summary

As timeout(9) interface was removed and all consumers were converted to callout(9), reference it instead in taskqueue(9) for the sbt, pr, and flags description.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Actually, there are more timeout(9) references, wonder if it would make sense to gather all of those in one review?

trasz added inline comments.
share/man/man9/taskqueue.9
516 ↗(On Diff #72771)

Missing coma?

yuripv added inline comments.
share/man/man9/taskqueue.9
516 ↗(On Diff #72771)

Last element in the list doesn't get one, lint actually warns if it does:

mandoc: share/man/man9/taskqueue.9:516:11: WARNING: unusual Xr punctuation: , after swi(9)

And yeah, I think it’s a good idea to fix all of them. Still, this is fine too.

share/man/man9/taskqueue.9
516 ↗(On Diff #72771)

Sigh, misread the patch. You’re of course right.

This revision is now accepted and ready to land.Jun 7 2020, 7:00 AM

And yeah, I think it’s a good idea to fix all of them. Still, this is fine too.

I'm just not sure how it would be easier to review, I could do all of those in one big wad, if it's preferable.