Page MenuHomeFreeBSD

locale: more output fixes
ClosedPublic

Authored by yuripv on Tue, Sep 10, 9:28 PM.

Details

Summary
  • make abday, day, abmon, mon, am_pm output quoting match linux
  • workaround localeconv() issue for mon_grouping and grouping (PR172215)
  • for other values not available in default locale, output -1 instead of 127 (CHAR_MAX) as returned by localeconv()

With these changes, output of locale and locale -k for all keywords
specified by POSIX exactly matches the linux one.

P.S. Baptiste, if I should include anyone else interested in reviewing locale stuff, please let me know.

Test Plan

New test cases provided, existing ones updated.

Compare the output of locale and locale -k for all POSIX specified keywords against linux.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuripv created this revision.Tue, Sep 10, 9:28 PM
bapt accepted this revision.Wed, Sep 11, 7:24 AM

This looks fine to me, tested locally with success.

Note that I am fine with reviewing the locale patches and I am not sure anyone else is really interested into locale stuff :(

This revision is now accepted and ready to land.Wed, Sep 11, 7:24 AM
This revision was automatically updated to reflect the committed changes.