hwpstate_intel: don't unconditionally print the error message
ClosedPublic
Actions

Authored by yuripv on May 7 2020, 3:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 9, 3:34 AM

	Unknown Object (File)
	Sat, Oct 4, 12:11 AM

	Unknown Object (File)
	Thu, Oct 2, 11:19 AM

	Unknown Object (File)
	Thu, Oct 2, 8:30 AM

	Unknown Object (File)
	Thu, Oct 2, 2:36 AM

	Unknown Object (File)
	Thu, Oct 2, 2:16 AM

	Unknown Object (File)
	Sep 7 2025, 8:04 PM

	Unknown Object (File)
	Aug 27 2025, 8:01 AM

View All 72 Files

Subscribers

imp

Details

Reviewers

cem

Commits

rS368140: hwpstate_intel: don't unconditionally print the error message

Summary

If CPU supports PKG-wide control MSR, hwpstate_intel unconditionally prints the "Failed to set autonomous HWP for package" error message, forgetting to check the actual wrmsr_safe() return value.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuripv created this revision.May 7 2020, 3:43 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2020, 3:43 AM

yuripv requested review of this revision.May 7 2020, 3:43 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2020, 1:43 AM

Closed by commit rS368140: hwpstate_intel: don't unconditionally print the error message (authored by yuripv). · Explain Why

This revision was automatically updated to reflect the committed changes.

yuripv added a commit: rS368140: hwpstate_intel: don't unconditionally print the error message.

Revision Contents
Changeset List

Path

Size

head/

sys/

x86/

cpufreq/

hwpstate_intel.c

6 lines

Diff 80106

View Options

head/sys/x86/cpufreq/hwpstate_intel.c

hwpstate_intel: don't unconditionally print the error messageClosedPublicActions