Paths

Table of Contentst

Differential D27690

rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY
ClosedPublic
Actions

Authored by freebsd_igalic.co on Dec 20 2020, 7:23 PM.

Tags

Referenced Files

	F122804471: D27690.id80984.diff
	Tue, Jul 8, 10:20 AM

	Unknown Object (File)
	Fri, Jul 4, 6:02 AM

	Unknown Object (File)
	Mon, Jun 30, 4:46 AM

	Unknown Object (File)
	Sun, Jun 29, 3:33 AM

	Unknown Object (File)
	Fri, Jun 27, 10:01 PM

	Unknown Object (File)
	Fri, Jun 27, 2:18 AM

	Unknown Object (File)
	Wed, Jun 25, 1:57 PM

	Unknown Object (File)
	Tue, Jun 24, 11:14 PM

Subscribers

Details

Reviewers

manu
bapt

Group Reviewers

manpages
pkgbase

Commits

rG4401fa9bf1a3: pkgbase: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY

Summary

this way, it'll be automatically picked up by poudriere
That's quite handy when building pkgbase!

Test Plan

https://github.com/freebsd/poudriere/issues/812
rebuild pkgbase with this
are packages signed?

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freebsd_igalic.co created this revision.Dec 20 2020, 7:23 PM

Herald added a reviewer: manpages. · View Herald TranscriptDec 20 2020, 7:23 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

freebsd_igalic.co requested review of this revision.Dec 20 2020, 7:23 PM

manu accepted this revision.Dec 20 2020, 7:24 PM

This revision is now accepted and ready to land.Dec 20 2020, 7:24 PM

yuripv added a subscriber: yuripv.Dec 20 2020, 7:30 PM

yuripv added inline comments.

share/man/man5/make.conf.5
447	It's `It` (caps i), not `lt` (small el).
450	I don't think it's great reference, as it links to utility, not file format/algorithm description (and it seems we don't have one?).

freebsd_igalic.co updated this revision to Diff 80984.Dec 20 2020, 8:18 PM

This revision now requires review to proceed.Dec 20 2020, 8:18 PM

address @yuripv's comments.

OK from manpages.

freebsd_igalic.co added a reviewer: pkgbase.Dec 24 2020, 12:16 PM

freebsd_igalic.co changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

bapt accepted this revision.Jan 4 2021, 1:26 PM

This revision is now accepted and ready to land.Jan 4 2021, 1:26 PM

Closed by commit rG4401fa9bf1a3: pkgbase: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY (authored by manu). · Explain WhyJan 4 2021, 3:26 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG4401fa9bf1a3: pkgbase: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY.

Revision Contents
Changeset List

Path

Size

4 lines

share/

man/

man5/

12 lines

Diff 81627

Makefile.inc1

Loading...

share/man/man5/make.conf.5

Loading...