lib9p: Make it a private library
ClosedPublic
Actions

Authored by markj on Thu, Aug 13, 3:55 PM.

Details

Reviewers

emaste
jhb

Commits

rG1b8ccb02ac72: lib9p: Make it a private library

Summary

lib9p was imported to add a 9p server to bhyve (and I believe this was
the original motivation for writing it in the first place). Its
external interfaces are kind of strange (from first-hand experience
using it to implement an inetd-based 9p server) and undocumented.
Moreover, upstream has been inactive for over five years.

I suspect there are no third-party consumers. Let's make it a private
library for now. If we get more code written against it and some
documentation, we can revisit this decision.

PR: 297499

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75567
Build 72450: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Aug 13, 3:55 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptThu, Aug 13, 3:55 PM

Harbormaster completed remote builds in B75567: Diff 183994.Thu, Aug 13, 3:55 PM

markj requested review of this revision.Thu, Aug 13, 3:55 PM

I'll request an exp-run for this.

The change is directly motivated by D58633, but I've wanted to do this since I tried writing a 9p server using this library earlier this year. The library interfaces don't give you much control, e.g., you're forced to use some statically sized thread pool to serve requests. It'd be nice to simplify and clean up the interface, and that's much easier to do if this library is private.