Page MenuHomeFreeBSD

lib9p: Make it a private library
AcceptedPublic

Authored by markj on Thu, Aug 13, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 3:58 PM
Unknown Object (File)
Tue, Aug 18, 8:00 PM
Unknown Object (File)
Thu, Aug 13, 4:21 PM
Subscribers

Details

Reviewers
emaste
jhb
Summary

lib9p was imported to add a 9p server to bhyve (and I believe this was
the original motivation for writing it in the first place). Its
external interfaces are kind of strange (from first-hand experience
using it to implement an inetd-based 9p server) and undocumented.
Moreover, upstream has been inactive for over five years.

I suspect there are no third-party consumers. Let's make it a private
library for now. If we get more code written against it and some
documentation, we can revisit this decision.

PR: 297499

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75567
Build 72450: arc lint + arc unit

Event Timeline

markj requested review of this revision.Thu, Aug 13, 3:55 PM

I'll request an exp-run for this.

The change is directly motivated by D58633, but I've wanted to do this since I tried writing a 9p server using this library earlier this year. The library interfaces don't give you much control, e.g., you're forced to use some statically sized thread pool to serve requests. It'd be nice to simplify and clean up the interface, and that's much easier to do if this library is private.

Yeah, I think this is reasonable (once the exp-run completes), we can make it a public library later on if there's a reason for it.

This revision is now accepted and ready to land.Thu, Aug 13, 4:52 PM
jhb added a subscriber: jhb.

I presume the QEMU 9pfs support doesn't depend on this?

In D58828#1353034, @jhb wrote:

I presume the QEMU 9pfs support doesn't depend on this?

Definitely not, QEMU has its own 9p server.