Page MenuHomeFreeBSD
Differential D54528

hwpstate{_amd,intel}(4): Move common knobs to a separate file
ClosedPublic
Actions

Authored by olce on Jan 5 2026, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 1, 1:55 PM
Unknown Object (File)
Sat, Feb 28, 12:59 PM
Unknown Object (File)
Mon, Feb 16, 4:25 PM
Unknown Object (File)
Mon, Feb 16, 8:39 AM
Unknown Object (File)
Mon, Feb 9, 10:29 PM
Unknown Object (File)
Tue, Feb 3, 3:27 PM
Unknown Object (File)
Jan 30 2026, 3:24 PM
Unknown Object (File)
Jan 26 2026, 11:27 AM
View All 20 Files
Subscribers
cy
emaste
guest-seuros
imp

Details

Reviewers
markj
khng
aokblast
emaste
Commits
rG804329587508: hwpstate{_amd,intel}(4): Move common knobs to a separate file
Summary

This is to avoid conflict for 'machdep.hwpstate_pkg_ctrl' for the time
being (I expect to remove it for hwpstate_amd(4) at some point), but may
prove useful for other knobs, such as 'debug.hwpstate_verbose' (which is
currently not used in Intel's driver).

Fixes: 3e6e4e4a0d42 ("hwpstate: add CPPC support for pstate driver on AMD")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70466
Build 67349: arc lint + arc unit

Event Timeline

aokblast created this revision.Jan 5 2026, 3:23 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 5 2026, 3:23 PM
aokblast requested review of this revision.Jan 5 2026, 3:23 PM
Harbormaster completed remote builds in B69626: Diff 169067.Jan 5 2026, 3:23 PM
aokblast added reviewers: markj, olce, khng.Jan 5 2026, 3:23 PM
markj added inline comments.Jan 5 2026, 3:29 PM
sys/x86/cpufreq/hwpstate_amd.c
365

This definitely needs some comment explaining why we register the sysctls this way.

olce mentioned this in D49587: hwpstate: add CPPC support for pstate driver on AMD.Jan 5 2026, 3:50 PM
olce added inline comments.Jan 5 2026, 4:13 PM
sys/x86/cpufreq/hwpstate_amd.c
366–376

While it does not hurt per se, I would not move the above knobs here, as they do not exist in the Intel driver and my plan is to remove machdep.hwpstate_pkg_ctrl both here and in the Intel driver in favor of a common knob under dev.hwpstate_* to set all cores' EPP, which could later lead to removing hwpstate_modevent().

cy added a subscriber: cy.Tue, Feb 3, 3:26 PM
emaste added a subscriber: emaste.Wed, Feb 4, 2:03 PM
olce mentioned this in D55139: cpufreq: Fix sysctl name conflict between hwpstate_intel and hwpstate_amd.Fri, Feb 6, 9:16 AM
olce commandeered this revision.Fri, Feb 6, 11:02 AM
olce edited reviewers, added: aokblast; removed: olce.

"Simpler" approach with some common file holding the common sysctl knobs. As said, I anticipate that machdep.hwpstate_pkg_ctrl will be removed from hwpstate_amd, but debug.hwpstate_verbose will probably stay and start to be used in hwpstate_intel as well. There are other knobs in hwpstate_amd that might become relevant for Intel too, but I haven't spent too much time on them, they could be moved later.

olce added a reviewer: emaste.Fri, Feb 6, 11:02 AM
olce updated this revision to Diff 171324.Fri, Feb 6, 11:03 AM
olce retitled this revision from hwpstate: Use dynamic sysctl initialization to hwpstate{_amd,intel}(4): Move common knobs to a separate file.
olce edited the summary of this revision. (Show Details)

New approach

Harbormaster completed remote builds in B70466: Diff 171324.Fri, Feb 6, 11:03 AM
olce added inline comments.Fri, Feb 6, 11:04 AM
sys/sys/sysctl.h
38–40

Oops, that part to be committed separately (and could be changed if someone objects to including sys/types.h from sys/sysctl.h).

guest-seuros added a subscriber: guest-seuros.Fri, Feb 6, 12:08 PM
emaste added a comment.Fri, Feb 6, 2:38 PM

Seems reasonable to me

sys/conf/files.x86
344

should sort in alpha order

olce marked an inline comment as done.Fri, Feb 6, 3:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 6, 4:23 PM
Closed by commit rG804329587508: hwpstate{_amd,intel}(4): Move common knobs to a separate file (authored by olce). · Explain Why
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG804329587508: hwpstate{_amd,intel}(4): Move common knobs to a separate file.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
modules/
cpufreq/
3 lines
sys/
3 lines
x86/
cpufreq/
11 lines
13 lines
22 lines
6 lines

Diff 171324

View Options

sys/conf/files.x86

Loading...
View Options

sys/modules/cpufreq/Makefile

Loading...
View Options

sys/sys/sysctl.h

Loading...
View Options

sys/x86/cpufreq/hwpstate_amd.c

Loading...
View Options

sys/x86/cpufreq/hwpstate_common.h

Loading...
View Options

sys/x86/cpufreq/hwpstate_common.c

Loading...
View Options

sys/x86/cpufreq/hwpstate_intel.c

Loading...