Page MenuHomeFreeBSD
Differential D55629

hwpstate_intel: Use 8bit scale instead of percentage scale
Needs ReviewPublic
Actions

Authored by aokblast on Mar 3 2026, 10:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 9:46 PM
Unknown Object (File)
Sat, Apr 18, 7:37 PM
Unknown Object (File)
Sat, Apr 18, 3:44 AM
Unknown Object (File)
Sat, Apr 11, 10:31 AM
Unknown Object (File)
Tue, Apr 7, 12:07 AM
Unknown Object (File)
Sun, Apr 5, 2:41 AM
Unknown Object (File)
Mon, Mar 30, 9:46 AM
Unknown Object (File)
Mar 17 2026, 7:32 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
olce

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71810
Build 68693: arc lint + arc unit

Event Timeline

aokblast created this revision.Mar 3 2026, 10:17 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2026, 10:17 AM
aokblast requested review of this revision.Mar 3 2026, 10:17 AM
Harbormaster completed remote builds in B71149: Diff 173051.Mar 3 2026, 10:17 AM
aokblast added a reviewer: olce.Mar 4 2026, 5:51 AM
olce added a comment.Thu, Mar 26, 3:05 PM

Some suggested changes, looks good.

sys/x86/cpufreq/hwpstate_intel.c
223–224

In order to send [0;15] to the full [0;255] range (so that 255 is reported when EPB is set to 15), I'd rather use multiply by 17 (please add a small comment about that).

224
aokblast updated this revision to Diff 174517.Mon, Mar 30, 7:09 AM

Minor fixes

Harbormaster completed remote builds in B71810: Diff 174517.Mon, Mar 30, 7:09 AM

Revision Contents
Changeset List

PathSize
sys/
x86/
cpufreq/
60 lines

Diff 174517

View Options

sys/x86/cpufreq/hwpstate_intel.c

Loading...