Differential D55629

hwpstate_intel: Use 8bit scale instead of percentage scale
ClosedPublic
Actions

Authored by aokblast on Mar 3 2026, 10:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 20, 7:14 PM

	Unknown Object (File)
	Thu, Aug 20, 6:32 AM

	Unknown Object (File)
	Tue, Aug 18, 5:39 AM

	Unknown Object (File)
	Thu, Aug 13, 12:14 PM

	Unknown Object (File)
	Thu, Aug 13, 12:14 PM

	Unknown Object (File)
	Thu, Aug 13, 12:13 PM

	Unknown Object (File)
	Thu, Aug 13, 12:35 AM

	Unknown Object (File)
	Mon, Aug 10, 12:04 PM

View All 70 Files

Subscribers

Details

Reviewers

Commits

rG8452afeb5682: hwpstate_intel: Use 8bit scale instead of percentage scale

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71810
Build 68693: arc lint + arc unit

Event Timeline

aokblast created this revision.Mar 3 2026, 10:17 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2026, 10:17 AM

aokblast requested review of this revision.Mar 3 2026, 10:17 AM

Harbormaster completed remote builds in B71149: Diff 173051.Mar 3 2026, 10:17 AM

aokblast added a reviewer: olce.Mar 4 2026, 5:51 AM

Some suggested changes, looks good.

sys/x86/cpufreq/hwpstate_intel.c
223–224	In order to send [0;15] to the full [0;255] range (so that 255 is reported when EPB is set to 15), I'd rather use multiply by 17 (please add a small comment about that).
224

Minor fixes

Harbormaster completed remote builds in B71810: Diff 174517.Mar 30 2026, 7:09 AM

olce accepted this revision.Jun 24 2026, 3:52 PM

This revision is now accepted and ready to land.Jun 24 2026, 3:52 PM

Closed by commit rG8452afeb5682: hwpstate_intel: Use 8bit scale instead of percentage scale (authored by aokblast). · Explain WhyJun 24 2026, 6:19 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG8452afeb5682: hwpstate_intel: Use 8bit scale instead of percentage scale.

Herald added a subscriber: ziaee. · View Herald TranscriptJun 24 2026, 6:19 PM

olce mentioned this in rG66d48f02de0f: hwpstate_intel(4): Comment the EPB to EPP computation.Jun 25 2026, 12:28 AM

markj added a subscriber: markj.Wed, Aug 12, 5:46 PM

markj added inline comments.

sys/x86/cpufreq/hwpstate_intel.c
539	This sysctl description needs to be updated, now the upper limit is 255.

Yes, I've noticed it also and is addressed in one of my staged commits. I'm AFK till the end of the month, though.

Revision Contents
Changeset List

Path

Size

sys/

x86/

cpufreq/

hwpstate_intel.c

60 lines

Diff 174517

sys/x86/cpufreq/hwpstate_intel.c

Loading...